Re: [PATCH 0/7] minor trace fixes and cosmetic improvements

2016-08-03 Thread Jeff King
On Wed, Aug 03, 2016 at 06:56:00PM -0400, Jeff King wrote: > On Wed, Aug 03, 2016 at 05:39:20PM -0400, Jeff King wrote: > > > Thinking about (2), I'd go so far as to say that the trace actually > > should just be using: > > > > if (write_in_full(...) < 0) > > warning("unable to write

[PATCH 0/7] minor trace fixes and cosmetic improvements

2016-08-03 Thread Jeff King
On Wed, Aug 03, 2016 at 05:39:20PM -0400, Jeff King wrote: > Thinking about (2), I'd go so far as to say that the trace actually > should just be using: > > if (write_in_full(...) < 0) > warning("unable to write trace to ...: %s", strerror(errno)); > > and we should get rid of