Re: [PATCH 00/37] removal of some c++ keywords

2018-01-30 Thread Duy Nguyen
On Wed, Jan 31, 2018 at 7:57 AM, Stefan Beller wrote: >> There's also C99 designator in builtin/clean.c (I thought we avoided >> C99, I can start using this specific feature more now :D) > > That was a test balloon? See 512f41cfac > (clean.c: use designated initializer,

Re: [PATCH 00/37] removal of some c++ keywords

2018-01-30 Thread Stefan Beller
On Tue, Jan 30, 2018 at 4:48 PM, Duy Nguyen wrote: > On Wed, Jan 31, 2018 at 6:01 AM, Stefan Beller wrote: >> On Tue, Jan 30, 2018 at 2:36 PM, Junio C Hamano wrote: >>> Duy Nguyen writes: >>> Is it simpler

Re: [PATCH 00/37] removal of some c++ keywords

2018-01-30 Thread Duy Nguyen
On Wed, Jan 31, 2018 at 6:01 AM, Stefan Beller wrote: > On Tue, Jan 30, 2018 at 2:36 PM, Junio C Hamano wrote: >> Duy Nguyen writes: >> >>> Is it simpler (though hacky) to just do >>> >>> #ifdef __cplusplus >>> #define new not_new >>>

Re: [PATCH 00/37] removal of some c++ keywords

2018-01-30 Thread Stefan Beller
On Tue, Jan 30, 2018 at 2:36 PM, Junio C Hamano wrote: > Duy Nguyen writes: > >> Is it simpler (though hacky) to just do >> >> #ifdef __cplusplus >> #define new not_new >> #define try really_try >> ... >> >> somewhere in git-compat-util.h? > > Very

Re: [PATCH 00/37] removal of some c++ keywords

2018-01-30 Thread Junio C Hamano
Duy Nguyen writes: > Is it simpler (though hacky) to just do > > #ifdef __cplusplus > #define new not_new > #define try really_try > ... > > somewhere in git-compat-util.h? Very tempting, especially given that your approach automatically would cover topics in flight without

Re: [PATCH 00/37] removal of some c++ keywords

2018-01-30 Thread Johannes Sixt
Am 29.01.2018 um 23:36 schrieb Brandon Williams: A while back there was some discussion of getting our codebase into a state where we could use a c++ compiler if we wanted to (for various reason like leveraging c++ only analysis tools, etc.). Johannes Sixt had a very large patch that achieved

Re: [PATCH 00/37] removal of some c++ keywords

2018-01-29 Thread Duy Nguyen
On Tue, Jan 30, 2018 at 5:36 AM, Brandon Williams wrote: > A while back there was some discussion of getting our codebase into a state > where we could use a c++ compiler if we wanted to (for various reason like > leveraging c++ only analysis tools, etc.). Johannes Sixt had a

[PATCH 00/37] removal of some c++ keywords

2018-01-29 Thread Brandon Williams
A while back there was some discussion of getting our codebase into a state where we could use a c++ compiler if we wanted to (for various reason like leveraging c++ only analysis tools, etc.). Johannes Sixt had a very large patch that achieved this but it wasn't in a state where it could be