Re: [PATCH 01/10] string_list: print_string_list to use trace_printf

2018-08-09 Thread Stefan Beller
On Thu, Aug 9, 2018 at 2:16 PM Junio C Hamano wrote: > > Stefan Beller writes: > > > It is a debugging aid, so it should print to the debugging channel. > > Who says? The comment in the header file? /** * Dump a string_list to stdout, useful mainly for debugging * purposes. It can take

Re: [PATCH 01/10] string_list: print_string_list to use trace_printf

2018-08-09 Thread Junio C Hamano
Stefan Beller writes: > It is a debugging aid, so it should print to the debugging channel. Who says? In-tree code may say so, and I do not think any in-flight topic up to 'pu' uses this to produce non-debugging output, but I do not think it is healthy attitude to assume that you can take over

[PATCH 01/10] string_list: print_string_list to use trace_printf

2018-08-08 Thread Stefan Beller
It is a debugging aid, so it should print to the debugging channel. Signed-off-by: Stefan Beller --- string-list.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/string-list.c b/string-list.c index 771c4550980..9f651bb4294 100644 --- a/string-list.c +++ b/string-list.c