[PATCH 03/12] MINGW: compat/mingw.h: do not attempt to redefine lseek on mingw-w64

2014-04-28 Thread Marat Radchenko
mingw-w64 has lseek defined in io.h. Signed-off-by: Marat Radchenko ma...@slonopotamus.org --- compat/mingw.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/compat/mingw.h b/compat/mingw.h index e033e72..262b300 100644 --- a/compat/mingw.h +++ b/compat/mingw.h @@ -265,7 +265,9 @@ static

Re: [PATCH 03/12] MINGW: compat/mingw.h: do not attempt to redefine lseek on mingw-w64

2014-04-28 Thread Erik Faye-Lund
On Mon, Apr 28, 2014 at 3:51 PM, Marat Radchenko ma...@slonopotamus.org wrote: mingw-w64 has lseek defined in io.h. msysGit has a declaration of it in io.h as well. But it's not a preprocessor-definition... Are you saying that it's a preprocessor-define in mingw-w64, that points to a 64-bit

Re: [PATCH 03/12] MINGW: compat/mingw.h: do not attempt to redefine lseek on mingw-w64

2014-04-28 Thread Marat Radchenko
On Mon, Apr 28, 2014 at 05:02:09PM +0200, Erik Faye-Lund wrote: msysGit has a declaration of it in io.h as well. But it's not a preprocessor-definition... Are you saying that it's a preprocessor-define in mingw-w64, that points to a 64-bit version? If so, looks good. MinGW is x86 only.

Re: [PATCH 03/12] MINGW: compat/mingw.h: do not attempt to redefine lseek on mingw-w64

2014-04-28 Thread Torsten Bögershausen
On 2014-04-28 15.51, Marat Radchenko wrote: mingw-w64 has lseek defined in io.h. [] #define off_t off64_t +#ifndef lseek #define lseek _lseeki64 +#endif Is the commit message in line with the code? I would have expected something in this style: #if defined(__x86_64__) ! defined(lseek))