Re: [PATCH 03/19] diff.c: drop 'nofirst' from emit_line_0

2017-05-16 Thread Jonathan Tan
On Mon, May 15, 2017 at 11:33 AM, Stefan Beller wrote: > On Mon, May 15, 2017 at 11:26 AM, Jonathan Tan > wrote: >> I also don't understand the meaning of this paragraph - if you mean that >> this patch teaches other callers to hardcode the sign, I

Re: [PATCH 03/19] diff.c: drop 'nofirst' from emit_line_0

2017-05-15 Thread Brandon Williams
On 05/15, Stefan Beller wrote: > On Mon, May 15, 2017 at 12:22 PM, Brandon Williams wrote: > > > Does the order of newline/carriage return always the same? > > https://en.wikipedia.org/wiki/Newline > > There are operating systems that like it the other way round. > The BBC

Re: [PATCH 03/19] diff.c: drop 'nofirst' from emit_line_0

2017-05-15 Thread Stefan Beller
On Mon, May 15, 2017 at 12:22 PM, Brandon Williams wrote: > Does the order of newline/carriage return always the same? https://en.wikipedia.org/wiki/Newline There are operating systems that like it the other way round. The BBC micro is no longer relevant (IMHO), but RISC OS

Re: [PATCH 03/19] diff.c: drop 'nofirst' from emit_line_0

2017-05-15 Thread Brandon Williams
On 05/13, Stefan Beller wrote: > In 250f79930d (diff.c: split emit_line() from the first char and the rest > of the line, 2009-09-14) we introduced the local variable 'nofirst' that > indicates if we have no first sign character. With the given implementation > we had to use an extra variable

Re: [PATCH 03/19] diff.c: drop 'nofirst' from emit_line_0

2017-05-15 Thread Stefan Beller
On Mon, May 15, 2017 at 11:26 AM, Jonathan Tan wrote: > "erroneous"? yep, words are hard. > > I also don't understand the meaning of this paragraph - if you mean that > this patch teaches other callers to hardcode the sign, I don't see any such > changes in the diff

Re: [PATCH 03/19] diff.c: drop 'nofirst' from emit_line_0

2017-05-15 Thread Jonathan Tan
On 05/13/2017 09:01 PM, Stefan Beller wrote: In 250f79930d (diff.c: split emit_line() from the first char and the rest of the line, 2009-09-14) we introduced the local variable 'nofirst' that indicates if we have no first sign character. With the given implementation we had to use an extra

[PATCH 03/19] diff.c: drop 'nofirst' from emit_line_0

2017-05-13 Thread Stefan Beller
In 250f79930d (diff.c: split emit_line() from the first char and the rest of the line, 2009-09-14) we introduced the local variable 'nofirst' that indicates if we have no first sign character. With the given implementation we had to use an extra variable unlike reusing 'first' because the lines