Re: [PATCH 03/31] config: don't implicitly use gitdir

2017-06-08 Thread Brandon Williams
On 06/08, Johannes Schindelin wrote: > Hi Brandon, > > On Thu, 8 Jun 2017, Brandon Williams wrote: > > > On 06/08, Johannes Schindelin wrote: > > > > > > On Wed, 31 May 2017, Brandon Williams wrote: > > > > > > > Commit 2185fde56 (config: handle conditional include when $GIT_DIR is > > > > not

Re: [PATCH 03/31] config: don't implicitly use gitdir

2017-06-08 Thread Johannes Schindelin
Hi Brandon, On Thu, 8 Jun 2017, Brandon Williams wrote: > On 06/08, Johannes Schindelin wrote: > > > > On Wed, 31 May 2017, Brandon Williams wrote: > > > > > Commit 2185fde56 (config: handle conditional include when $GIT_DIR is > > > not set up) added a 'git_dir' field to the config_options

Re: [PATCH 03/31] config: don't implicitly use gitdir

2017-06-08 Thread Brandon Williams
On 06/08, Johannes Schindelin wrote: > Hi Brandon, > > On Wed, 31 May 2017, Brandon Williams wrote: > > > Commit 2185fde56 (config: handle conditional include when $GIT_DIR is > > not set up) added a 'git_dir' field to the config_options struct. Let's > > use this option field explicitly all

Re: [PATCH 03/31] config: don't implicitly use gitdir

2017-06-08 Thread Johannes Schindelin
Hi Brandon, On Wed, 31 May 2017, Brandon Williams wrote: > Commit 2185fde56 (config: handle conditional include when $GIT_DIR is > not set up) added a 'git_dir' field to the config_options struct. Let's > use this option field explicitly all the time instead of occasionally > falling back to

[PATCH 03/31] config: don't implicitly use gitdir

2017-05-31 Thread Brandon Williams
Commit 2185fde56 (config: handle conditional include when $GIT_DIR is not set up) added a 'git_dir' field to the config_options struct. Let's use this option field explicitly all the time instead of occasionally falling back to calling 'git_pathdup("config")' to get the path to the local