Re: [PATCH 06/12] clone: disable save_commit_buffer

2017-01-25 Thread Jeff King
On Wed, Jan 25, 2017 at 02:35:41PM -0500, Jeff King wrote: > On Wed, Jan 25, 2017 at 02:27:40PM -0500, Jeff King wrote: > > > > > For fetching operations like clone, we already disable > > > > > > s/clone/fetch/ you meant? > > > > Well, no, because this patch deals with clone. > > > > It's

Re: [PATCH 06/12] clone: disable save_commit_buffer

2017-01-25 Thread Jeff King
On Wed, Jan 25, 2017 at 02:27:40PM -0500, Jeff King wrote: > > > For fetching operations like clone, we already disable > > > > s/clone/fetch/ you meant? > > Well, no, because this patch deals with clone. > > It's likely that builtin/fetch.c would want the same treatment. It > didn't come up

Re: [PATCH 06/12] clone: disable save_commit_buffer

2017-01-25 Thread Jeff King
On Wed, Jan 25, 2017 at 11:11:01AM -0800, Junio C Hamano wrote: > Jeff King writes: > > > Normally git caches the raw commit object contents in > > "struct commit". This makes it fast to run parse_commit() > > followed by a pretty-print operation. > > > > For commands which don't

Re: [PATCH 06/12] clone: disable save_commit_buffer

2017-01-25 Thread Junio C Hamano
Jeff King writes: > Normally git caches the raw commit object contents in > "struct commit". This makes it fast to run parse_commit() > followed by a pretty-print operation. > > For commands which don't actually pretty-print the commits, > the caching is wasteful (and may use

[PATCH 06/12] clone: disable save_commit_buffer

2017-01-23 Thread Jeff King
Normally git caches the raw commit object contents in "struct commit". This makes it fast to run parse_commit() followed by a pretty-print operation. For commands which don't actually pretty-print the commits, the caching is wasteful (and may use quite a lot of memory if git accesses a large