Re: [PATCH 07/19] diff.c: convert fn_out_consume to use emit_line_*

2017-05-16 Thread Stefan Beller
On Mon, May 15, 2017 at 6:05 PM, Junio C Hamano wrote: > Junio C Hamano writes: > >>> -fprintf(o->file, "%s%s--- %s%s%s\n", >>> -line_prefix, meta, ecbdata->label_path[0], reset, >>> name_a_tab); >>> -

Re: [PATCH 07/19] diff.c: convert fn_out_consume to use emit_line_*

2017-05-15 Thread Junio C Hamano
Junio C Hamano writes: >> -fprintf(o->file, "%s%s--- %s%s%s\n", >> -line_prefix, meta, ecbdata->label_path[0], reset, >> name_a_tab); >> -fprintf(o->file, "%s%s+++ %s%s%s\n", >> -line_prefix, meta,

Re: [PATCH 07/19] diff.c: convert fn_out_consume to use emit_line_*

2017-05-15 Thread Junio C Hamano
Stefan Beller writes: > In a later patch, I want to propose an option to detect > moved lines in a diff, which cannot be done in a one-pass over > the diff. Instead we need to go over the whole diff twice, > because we cannot detect the first line of the two corresponding >

[PATCH 07/19] diff.c: convert fn_out_consume to use emit_line_*

2017-05-13 Thread Stefan Beller
In a later patch, I want to propose an option to detect moved lines in a diff, which cannot be done in a one-pass over the diff. Instead we need to go over the whole diff twice, because we cannot detect the first line of the two corresponding lines (+ and -) that got moved. So to prepare the diff