[PATCH 1/1] Mark messages for translations

Small changes in messages to fit the style and typography of rest. Reuse already translated messages if possible. Do not translate messages aimed at developers of git. Fix unit tests depending on the original string. Use `test_i18ngrep` for tests with translatable strings. Change and verify rest

Re: [PATCH 1/1] Mark messages for translations

On Mon, Feb 12, 2018 at 04:03:49PM +0100, Alexander Shopov wrote: > @Jeff: > > we may want to avoid this anti-pattern > Current state of these tests is wrong and I should rework them. > > Here is what I intend to do: > 1. Fix the commit message > 2. Check whether I can get the tests in

Re: [PATCH 1/1] Mark messages for translations

Let me repeat what you said so I know how to improve the patch: @Junio: > Perhaps end each sentence with a full-stop? I should end each sentence in the *log* message with "." (rather than the translatable strings in the patch) > Shouldn't this rather be like so instead? > if test_i18ngrep !

Re: [PATCH 1/1] Mark messages for translations

On Fri, Feb 09, 2018 at 11:15:06AM -0800, Junio C Hamano wrote: > Junio C Hamano writes: > > >> - if ! grep "Invalid gitfile format" .err > >> + if ! test_i18ngrep "invalid gitfile format" .err > > > > Shouldn't this rather be like so instead? > > > > if test_i18ngrep !

Re: [PATCH 1/1] Mark messages for translations

Junio C Hamano writes: >> -if ! grep "Invalid gitfile format" .err >> +if ! test_i18ngrep "invalid gitfile format" .err > > Shouldn't this rather be like so instead? > > if test_i18ngrep ! "invalid gitfile format" .err > > Ditto for the other negated use of

Re: [PATCH 1/1] Mark messages for translations

Alexander Shopov writes: > Small changes in messages to fit the style and typography of rest > Reuse already translated messages if possible > Do not translate messages aimed at developers of git > Fix unit tests depending on the original string > Use `test_i18ngrep` for

[PATCH 1/1] Mark messages for translations

Small changes in messages to fit the style and typography of rest Reuse already translated messages if possible Do not translate messages aimed at developers of git Fix unit tests depending on the original string Use `test_i18ngrep` for tests with translatable strings Change and verifyrest of

Re: [PATCH 1/1] Mark messages for translations

On Tue, Feb 06, 2018 at 02:32:42AM -0500, Eric Sunshine wrote: > > diff --git a/t/t0002-gitfile.sh b/t/t0002-gitfile.sh > > @@ -31,7 +31,7 @@ test_expect_success 'bad setup: invalid .git file format' > > ' > > echo "git rev-parse accepted an invalid .git file" > >

Re: [PATCH 1/1] Mark messages for translations

On Tue, Feb 6, 2018 at 1:15 AM, Alexander Shopov wrote: > Small changes in messages to fit the style and typography of rest > Reuse already translated messages if possible > Do not translate messages aimed at developers of git > Fix unit tests depending on the original string

[PATCH 1/1] Mark messages for translations

Small changes in messages to fit the style and typography of rest Reuse already translated messages if possible Do not translate messages aimed at developers of git Fix unit tests depending on the original string Signed-off-by: Alexander Shopov --- git.c | 38

Re: [PATCH 1/1] Mark messages for translations

On Mon, Jan 15, 2018 at 12:44 PM, Alexander Shopov wrote: > @@ -160,7 +160,7 @@ int check_filename(const char *prefix, const char *arg) > free(to_free); > return 0; /* file does not exist */ > } > - die_errno("failed to stat

Re: [PATCH 1/1] Mark messages for translations

On Mon, Jan 15, 2018 at 12:44 AM, Alexander Shopov wrote: > Reuse already translated messages if possible > Do not translate messages aimed at developers of git A couple comments beyond those from Hannes... > Signed-off-by: Alexander Shopov > --- >

Re: [PATCH 1/1] Mark messages for translations

And again, sigh: >> const char git_usage_string[] = >> const char git_more_info_string[] = > It is not obvious to me where git_usage_string is looked up in the > message catalog. It is used that way in builtin/help.c .. I wanted to be consistent with the current state of the file. This

Re: [PATCH 1/1] Mark messages for translations

Am 15.01.2018 um 06:44 schrieb Alexander Shopov: @@ -5,11 +5,11 @@ #include "run-command.h" const char git_usage_string[] = - "git [--version] [--help] [-C ] [-c name=value]\n" - " [--exec-path[=]] [--html-path] [--man-path] [--info-path]\n" - " [-p

[PATCH 1/1] Mark messages for translations

Reuse already translated messages if possible Do not translate messages aimed at developers of git Signed-off-by: Alexander Shopov --- git.c | 30 +++--- setup.c | 52 ++-- 2 files changed, 41