Re: [PATCH 11/12] receive-pack: treat namespace .have lines like alternates

2017-01-27 Thread Junio C Hamano
Jeff King writes: > On Fri, Jan 27, 2017 at 06:45:26PM +0100, Lukas Fleischer wrote: > >> I think this is already possible using receive.hideRefs (which causes >> the ref_is_hidden() branch above to return if applicable). >> ... > > Thanks for the pointers. I think a "turn off

Re: [PATCH 11/12] receive-pack: treat namespace .have lines like alternates

2017-01-27 Thread Jeff King
On Fri, Jan 27, 2017 at 06:45:26PM +0100, Lukas Fleischer wrote: > > This is an unrelated tangent, but there may want to be a knob to > > make the code return here without even showing, to make the > > advertisement even smaller and also to stop miniscule information > > leakage? If the

Re: [PATCH 11/12] receive-pack: treat namespace .have lines like alternates

2017-01-27 Thread Lukas Fleischer
On Wed, 25 Jan 2017 at 20:51:17, Junio C Hamano wrote: > [...] > > diff --git a/builtin/receive-pack.c b/builtin/receive-pack.c > > index 8f8762e4a..c55e2f993 100644 > > --- a/builtin/receive-pack.c > > +++ b/builtin/receive-pack.c > > @@ -251,8 +251,9 @@ static void show_ref(const char *path,

Re: [PATCH 11/12] receive-pack: treat namespace .have lines like alternates

2017-01-25 Thread Jeff King
On Wed, Jan 25, 2017 at 11:51:17AM -0800, Junio C Hamano wrote: > This is an unrelated tangent, but there may want to be a knob to > make the code return here without even showing, to make the > advertisement even smaller and also to stop miniscule information > leakage? If the namespaced

Re: [PATCH 11/12] receive-pack: treat namespace .have lines like alternates

2017-01-25 Thread Junio C Hamano
Jeff King writes: > Namely, de-duplicate them. We use the same set as the > alternates, since we call them both ".have" (i.e., there is > no value in showing one versus the other). > > Signed-off-by: Jeff King > --- > builtin/receive-pack.c | 10 +++--- > 1

[PATCH 11/12] receive-pack: treat namespace .have lines like alternates

2017-01-23 Thread Jeff King
Namely, de-duplicate them. We use the same set as the alternates, since we call them both ".have" (i.e., there is no value in showing one versus the other). Signed-off-by: Jeff King --- builtin/receive-pack.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff