Re: [PATCH 2/2] diff: fix a double off-by-one with --ignore-space-at-eol

2016-07-11 Thread Junio C Hamano
Johannes Schindelin writes: > diff --git a/xdiff/xutils.c b/xdiff/xutils.c > index 62cb23d..027192a 100644 > --- a/xdiff/xutils.c > +++ b/xdiff/xutils.c > @@ -200,8 +200,10 @@ int xdl_recmatch(const char *l1, long s1, const char > *l2, long s2, long flags) >

Re: [PATCH 2/2] diff: fix a double off-by-one with --ignore-space-at-eol

2016-07-09 Thread Naja Melan
Thanks, you sure are efficient in bug fixing... good day to you Naja Melan -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH 2/2] diff: fix a double off-by-one with --ignore-space-at-eol

2016-07-09 Thread Johannes Schindelin
When comparing two lines, ignoring any whitespace at the end, we first try to match as many bytes as possible and break out of the loop only upon mismatch, to let the remainder be handled by the code shared with the other whitespace-ignoring code paths. When comparing the bytes, however, we