[PATCH 2/4] do not send client agent unless server does first

2012-08-10 Thread Jeff King
Commit ff5effdf taught both clients and servers of the git protocol to send an agent capability that just advertises their version for statistics and debugging purposes. However, the protocol-capabilities.txt document indicates that the client's advertisement is actually a response, and should

Re: [PATCH 2/4] do not send client agent unless server does first

2012-08-10 Thread Junio C Hamano
Jeff King p...@peff.net writes: Instead, each client must record whether we saw an agent string from the server, and respond with its agent only if the server mentioned it first. Just a couple of minor comments. diff --git a/builtin/fetch-pack.c b/builtin/fetch-pack.c index

Re: [PATCH 2/4] do not send client agent unless server does first

2012-08-10 Thread Jeff King
On Fri, Aug 10, 2012 at 12:45:19PM -0700, Junio C Hamano wrote: diff --git a/builtin/fetch-pack.c b/builtin/fetch-pack.c index fe56596..bc7a0f9 100644 --- a/builtin/fetch-pack.c +++ b/builtin/fetch-pack.c @@ -19,6 +19,7 @@ static int prefer_ofs_delta = 1; static int no_done;