Re: [PATCH 32/36] pathspec: allow querying for attributes

2016-11-09 Thread Junio C Hamano
Stefan Beller writes: > On Wed, Nov 9, 2016 at 1:45 AM, Duy Nguyen wrote: >> On Fri, Oct 28, 2016 at 1:29 AM, Junio C Hamano wrote: >>> ... >>> The strategy this round takes to make it unnecessary to punt >>> preloading (i.e. dropping

Re: [PATCH 32/36] pathspec: allow querying for attributes

2016-11-09 Thread Stefan Beller
On Wed, Nov 9, 2016 at 1:45 AM, Duy Nguyen wrote: > On Fri, Oct 28, 2016 at 1:29 AM, Junio C Hamano wrote: >> The reason why I am bringing this up in this discussion thread on >> this patch is because I wonder if we would benefit by a similar >> "let's not

Re: [PATCH 32/36] pathspec: allow querying for attributes

2016-11-09 Thread Duy Nguyen
On Fri, Oct 28, 2016 at 1:29 AM, Junio C Hamano wrote: > The reason why I am bringing this up in this discussion thread on > this patch is because I wonder if we would benefit by a similar > "let's not do too involved things and be cheap by erring on the safe > and lazy side"

Re: [PATCH 32/36] pathspec: allow querying for attributes

2016-10-27 Thread Stefan Beller
On Wed, Oct 26, 2016 at 6:33 AM, Duy Nguyen wrote: > (sorry if this should have been answered if I went through the series > patch by patch, I wanted to do a proper review but finally have to > admit to myself I won't, so I just skim through a single giant diff > instead) > >

Re: [PATCH 32/36] pathspec: allow querying for attributes

2016-10-27 Thread Junio C Hamano
Stefan Beller writes: > The pathspec mechanism is extended via the new > ":(attr:eol=input)pattern/to/match" syntax to filter paths so that it > requires paths to not just match the given pattern but also have the > specified attrs attached for them to be chosen. I was

Re: [PATCH 32/36] pathspec: allow querying for attributes

2016-10-26 Thread Duy Nguyen
(sorry if this should have been answered if I went through the series patch by patch, I wanted to do a proper review but finally have to admit to myself I won't, so I just skim through a single giant diff instead) On Sun, Oct 23, 2016 at 6:32 AM, Stefan Beller wrote: >

[PATCH 32/36] pathspec: allow querying for attributes

2016-10-22 Thread Stefan Beller
The pathspec mechanism is extended via the new ":(attr:eol=input)pattern/to/match" syntax to filter paths so that it requires paths to not just match the given pattern but also have the specified attrs attached for them to be chosen. Signed-off-by: Stefan Beller