Re: [PATCH 5/5] describe: teach describe negative pattern matches

2017-01-18 Thread Jacob Keller
On Wed, Jan 18, 2017 at 4:44 AM, Johannes Schindelin wrote: > Hi Jake, > > On Tue, 17 Jan 2017, Jacob Keller wrote: > >> On Fri, Jan 13, 2017 at 1:31 PM, Johannes Sixt wrote: >> > Am 13.01.2017 um 07:57 schrieb Jacob Keller: >> >> >> >> On Thu, Jan 12,

Re: [PATCH 5/5] describe: teach describe negative pattern matches

2017-01-18 Thread Johannes Schindelin
Hi Jake, On Tue, 17 Jan 2017, Jacob Keller wrote: > On Fri, Jan 13, 2017 at 1:31 PM, Johannes Sixt wrote: > > Am 13.01.2017 um 07:57 schrieb Jacob Keller: > >> > >> On Thu, Jan 12, 2017 at 10:43 PM, Johannes Sixt wrote: > >>> > >>> When you write > >>> > >>>

Re: [PATCH 5/5] describe: teach describe negative pattern matches

2017-01-17 Thread Jacob Keller
On Fri, Jan 13, 2017 at 1:31 PM, Johannes Sixt wrote: > Am 13.01.2017 um 07:57 schrieb Jacob Keller: >> >> On Thu, Jan 12, 2017 at 10:43 PM, Johannes Sixt wrote: >>> >>> When you write >>> >>> git log --branches --exclude=origin/* --remotes >>> >>>

Re: [PATCH 5/5] describe: teach describe negative pattern matches

2017-01-13 Thread Johannes Sixt
Am 13.01.2017 um 07:57 schrieb Jacob Keller: On Thu, Jan 12, 2017 at 10:43 PM, Johannes Sixt wrote: When you write git log --branches --exclude=origin/* --remotes --exclude=origin/* applies only to --remotes, but not to --branches. Well for describe I don't think the

Re: [PATCH 5/5] describe: teach describe negative pattern matches

2017-01-12 Thread Jacob Keller
On Thu, Jan 12, 2017 at 10:43 PM, Johannes Sixt wrote: > Am 13.01.2017 um 01:59 schrieb Jacob Keller: >> >> I think that --exclude makes sense, but the current implementation >> does not differentiate ordering, since both are merely accumulated >> into string_lists and then matched

Re: [PATCH 5/5] describe: teach describe negative pattern matches

2017-01-12 Thread Johannes Sixt
Am 13.01.2017 um 01:59 schrieb Jacob Keller: I think that --exclude makes sense, but the current implementation does not differentiate ordering, since both are merely accumulated into string_lists and then matched together. I'm not sure how order would impact things here? In the current

Re: [PATCH 5/5] describe: teach describe negative pattern matches

2017-01-12 Thread Jacob Keller
On Thu, Jan 12, 2017 at 5:45 AM, Johannes Sixt wrote: > Am 12.01.2017 um 01:17 schrieb Jacob Keller: >> >> From: Jacob Keller >> >> Teach git-describe the `--discard` option which will allow specifying >> a glob pattern of tags to ignore. This can be

Re: [PATCH 5/5] describe: teach describe negative pattern matches

2017-01-12 Thread Junio C Hamano
Johannes Schindelin writes: > Hi Jake, > > On Wed, 11 Jan 2017, Jacob Keller wrote: > >> From: Jacob Keller >> >> Teach git-describe the `--discard` option which will allow specifying >> a glob pattern of tags to ignore. > > IMHO "discard" is

Re: [PATCH 5/5] describe: teach describe negative pattern matches

2017-01-12 Thread Johannes Sixt
Am 12.01.2017 um 01:17 schrieb Jacob Keller: From: Jacob Keller Teach git-describe the `--discard` option which will allow specifying a glob pattern of tags to ignore. This can be combined with the `--match` patterns to enable more flexibility in determining which tags

Re: [PATCH 5/5] describe: teach describe negative pattern matches

2017-01-12 Thread Johannes Schindelin
Hi Jake, On Wed, 11 Jan 2017, Jacob Keller wrote: > From: Jacob Keller > > Teach git-describe the `--discard` option which will allow specifying > a glob pattern of tags to ignore. IMHO "discard" is the wrong word, it almost sounds as if the matching tags would be

[PATCH 5/5] describe: teach describe negative pattern matches

2017-01-11 Thread Jacob Keller
From: Jacob Keller Teach git-describe the `--discard` option which will allow specifying a glob pattern of tags to ignore. This can be combined with the `--match` patterns to enable more flexibility in determining which tags to consider. For example, suppose you wish to