Re: [PATCH 6/7] submodule-config: reuse config_from_gitmodules in repo_read_gitmodules

2018-06-22 Thread Brandon Williams
On 06/22, Antonio Ospite wrote: > Reuse config_from_gitmodules in repo_read_gitmodules to remove some > duplication and also have a single point where the .gitmodules file is > read. > > The change does not introduce any new behavior, the same gitmodules_cb > config callback is still used which

[PATCH 6/7] submodule-config: reuse config_from_gitmodules in repo_read_gitmodules

2018-06-22 Thread Antonio Ospite
Reuse config_from_gitmodules in repo_read_gitmodules to remove some duplication and also have a single point where the .gitmodules file is read. The change does not introduce any new behavior, the same gitmodules_cb config callback is still used which only deals with configuration specific to