Re: [PATCH 6.5?/8] version: move --build-options to a test helper

2017-05-31 Thread Jeff King
On Wed, May 31, 2017 at 07:51:20PM +0200, Ævar Arnfjörð Bjarmason wrote: > Thanks both. It makes sense to discard this patch. > > I wasn't sure whether anyone really cared about this, and thought a > patch was a better starting point of discussion. I will never complain about somebody starting

Re: [PATCH 6.5?/8] version: move --build-options to a test helper

2017-05-31 Thread Ævar Arnfjörð Bjarmason
On Wed, May 31, 2017 at 5:46 PM, Johannes Schindelin wrote: > Hi Peff, > > On Wed, 31 May 2017, Jeff King wrote: > >> On Wed, May 31, 2017 at 05:27:21PM +0200, Johannes Schindelin wrote: >> >> > > My intent in putting it into the actual git binary was that it could >>

Re: [PATCH 6.5?/8] version: move --build-options to a test helper

2017-05-31 Thread Johannes Schindelin
Hi Peff, On Wed, 31 May 2017, Jeff King wrote: > On Wed, May 31, 2017 at 05:27:21PM +0200, Johannes Schindelin wrote: > > > > My intent in putting it into the actual git binary was that it could > > > also be useful for collecting build-time knobs from users (who may be > > > using a binary

Re: [PATCH 6.5?/8] version: move --build-options to a test helper

2017-05-31 Thread Jeff King
On Wed, May 31, 2017 at 05:27:21PM +0200, Johannes Schindelin wrote: > > My intent in putting it into the actual git binary was that it could > > also be useful for collecting build-time knobs from users (who may be > > using a binary package). Like: > > > >

Re: [PATCH 6.5?/8] version: move --build-options to a test helper

2017-05-31 Thread Johannes Schindelin
Hi, On Tue, 30 May 2017, Jeff King wrote: > On Tue, May 30, 2017 at 08:45:53PM +, Ævar Arnfjörð Bjarmason wrote: > > > On Tue, May 30, 2017 at 7:17 AM, Jeff King wrote: > > > The "git version" command didn't traditionally accept any > > > options, and in fact ignores any you

Re: [PATCH 6.5?/8] version: move --build-options to a test helper

2017-05-30 Thread Jeff King
On Tue, May 30, 2017 at 08:45:53PM +, Ævar Arnfjörð Bjarmason wrote: > On Tue, May 30, 2017 at 7:17 AM, Jeff King wrote: > > The "git version" command didn't traditionally accept any > > options, and in fact ignores any you give it. When we added > > simple option parsing for

[PATCH 6.5?/8] version: move --build-options to a test helper

2017-05-30 Thread Ævar Arnfjörð Bjarmason
Move the undocumented --build-options argument to a test helper. It's purely used for testing git itself, so it belongs in a test helper instead of something that's part of the public plumbing. Signed-off-by: Ævar Arnfjörð Bjarmason --- On Tue, May 30, 2017 at 7:17 AM, Jeff