Re: [PATCH 7/7] Do not use curl_easy_strerror with curl < 7.12.0

2017-04-13 Thread Jacob Keller
On Wed, Apr 12, 2017 at 11:28 PM, Junio C Hamano wrote: > Jeff King writes: > >> On Wed, Apr 05, 2017 at 03:04:24PM +0200, Tom G. Christensen wrote: >> ... >> These kinds of interleaved conditionals make me nervous that we'll get >> something wrong (especially

Re: [PATCH 7/7] Do not use curl_easy_strerror with curl < 7.12.0

2017-04-13 Thread Junio C Hamano
Jeff King writes: > On Wed, Apr 05, 2017 at 03:04:24PM +0200, Tom G. Christensen wrote: > ... > These kinds of interleaved conditionals make me nervous that we'll get > something wrong (especially without braces, it's not immediately clear > that both sides are a single

Re: [PATCH 7/7] Do not use curl_easy_strerror with curl < 7.12.0

2017-04-06 Thread Jeff King
On Wed, Apr 05, 2017 at 03:04:24PM +0200, Tom G. Christensen wrote: > Commit 17966c0a added an unguarded use of curl_easy_strerror. > This adds a guard so it is not used with curl < 7.12.0. > > Signed-off-by: Tom G. Christensen > --- > http.c | 4 > 1 file changed, 4

Re: [PATCH 7/7] Do not use curl_easy_strerror with curl < 7.12.0

2017-04-05 Thread Ævar Arnfjörð Bjarmason
On Wed, Apr 5, 2017 at 3:04 PM, Tom G. Christensen wrote: > Commit 17966c0a added an unguarded use of curl_easy_strerror. > This adds a guard so it is not used with curl < 7.12.0. Looks good to me. Eric Wong added this in 17966c0a63. > Signed-off-by: Tom G. Christensen

[PATCH 7/7] Do not use curl_easy_strerror with curl < 7.12.0

2017-04-05 Thread Tom G. Christensen
Commit 17966c0a added an unguarded use of curl_easy_strerror. This adds a guard so it is not used with curl < 7.12.0. Signed-off-by: Tom G. Christensen --- http.c | 4 1 file changed, 4 insertions(+) diff --git a/http.c b/http.c index a46ab23af..104caaa75 100644 ---