Re: [PATCH sg/test-rebase-editor-fix] t3404-rebase-interactive: test abbreviated commands

2018-10-26 Thread Johannes Schindelin
Hi Hannes, On Thu, 25 Oct 2018, Johannes Sixt wrote: > Test each short command at least once. The commands changed here > are chosen such that I stumbled over this, and understood it only after looking at the patch. How about this instead: Make sure that each short command is tested

Re: [PATCH sg/test-rebase-editor-fix] t3404-rebase-interactive: test abbreviated commands

2018-10-25 Thread Johannes Sixt
Am 25.10.18 um 22:54 schrieb Johannes Sixt: Test each short command at least once. The commands changed here are chosen such that - tests do not have a prerequisite, - the 'git rebase' command is not guarded by test_must_fail. The pick commands are optional noise words in the FAKE_LINES

[PATCH sg/test-rebase-editor-fix] t3404-rebase-interactive: test abbreviated commands

2018-10-25 Thread Johannes Sixt
Test each short command at least once. The commands changed here are chosen such that - tests do not have a prerequisite, - the 'git rebase' command is not guarded by test_must_fail. The pick commands are optional noise words in the FAKE_LINES variable. Test them, too. Signed-off-by: Johannes