Re: [PATCH v2] core: use env variable instead of config var to turn on logging pack access

Nguyễn Thái Ngọc Duy pclo...@gmail.com writes: Have you ever tested this? Once log_pack_access goes to NULL (e.g. when it sees the empty string it was initialized to), this new test will happily dereference NULL. My bad. I did test when GIT_TRACE_PACK_ACCESS was set, not when it

Re: [PATCH v2] core: use env variable instead of config var to turn on logging pack access

On Tue, Jun 4, 2013 at 1:26 PM, Junio C Hamano gits...@pobox.com wrote: Nguyễn Thái Ngọc Duy pclo...@gmail.com writes: Have you ever tested this? Once log_pack_access goes to NULL (e.g. when it sees the empty string it was initialized to), this new test will happily dereference