subject:"\[PATCH v2\] t\/test\-lib\: make `test_dir_is_empty` more robust"

Re: [PATCH v2] t/test-lib: make `test_dir_is_empty` more robust

2018-08-05 Thread Johannes Sixt

Am 05.08.2018 um 06:20 schrieb William Chargin: While the `test_dir_is_empty` function appears correct in most normal use cases, it can fail when filenames contain newlines. This patch changes the implementation to use `ls -A`, which is specified by POSIX. The output should be empty exactly if

[PATCH v2] t/test-lib: make `test_dir_is_empty` more robust

2018-08-04 Thread William Chargin

While the `test_dir_is_empty` function appears correct in most normal use cases, it can fail when filenames contain newlines. This patch changes the implementation to use `ls -A`, which is specified by POSIX. The output should be empty exactly if the directory is empty. The newly added unit test