Re: [PATCH v2 04/29] log: add exhaustive tests for pattern style options & config

Ævar Arnfjörð Bjarmason writes: > On Mon, May 15, 2017 at 6:57 AM, Junio C Hamano wrote: >> Ævar Arnfjörð Bjarmason writes: >>> + if test_have_prereq PCRE >>> + then >>> + # Only PCRE would

Re: [PATCH v2 04/29] log: add exhaustive tests for pattern style options & config

On Mon, May 15, 2017 at 6:57 AM, Junio C Hamano wrote: > Ævar Arnfjörð Bjarmason writes: > >> + echo 2e >expect && >> + # In PCRE \d in [\d] is like saying "0-9", and matches the 2 >> + # in 2e... >> + git -C num_commits log -1

Re: [PATCH v2 04/29] log: add exhaustive tests for pattern style options & config

Ævar Arnfjörð Bjarmason writes: > + echo 2e >expect && > + # In PCRE \d in [\d] is like saying "0-9", and matches the 2 > + # in 2e... > + git -C num_commits log -1 --pretty="tformat:%s" -F -E --perl-regexp > --grep="[\d]" >actual && > + test_cmp expect

[PATCH v2 04/29] log: add exhaustive tests for pattern style options & config

Add exhaustive tests for how the different grep.patternType options & the corresponding command-line options affect git-log. Before this change it was possible to patch revision.c so that the --basic-regexp option was synonymous with --extended-regexp, and --perl-regexp wasn't recognized at all,