Re: [PATCH v2 1/2] auto gc: don't write bitmaps for incremental repacks

2016-12-23 Thread Jeff King
On Fri, Dec 23, 2016 at 02:43:34PM -0500, David Turner wrote: > When git gc --auto does an incremental repack of loose objects, we do > not expect to be able to write a bitmap; it is very likely that > objects in the new pack will have references to objects outside of the > pack. So we shouldn't

Re: [PATCH v2 1/2] auto gc: don't write bitmaps for incremental repacks

2016-12-23 Thread Junio C Hamano
David Turner writes: > +test_expect_success 'auto gc with too many loose objects does not attempt to > create bitmaps' ' > + test_config gc.auto 3 && > + test_config gc.autodetach false && > + test_config pack.writebitmaps true && > + # We need to create two object whose sha1s st

[PATCH v2 1/2] auto gc: don't write bitmaps for incremental repacks

2016-12-23 Thread David Turner
When git gc --auto does an incremental repack of loose objects, we do not expect to be able to write a bitmap; it is very likely that objects in the new pack will have references to objects outside of the pack. So we shouldn't try to write a bitmap, because doing so will likely issue a warning. T