Re: [PATCH v2 2/2] i18n: mark OPTION_NUMBER (-NUM) for translation

On Wed, Feb 6, 2013 at 11:35 AM, Junio C Hamano gits...@pobox.com wrote: How about this since [PATCH v3]: diff --git a/utf8.c b/utf8.c index 52dbd..b893a 100644 --- a/utf8.c +++ b/utf8.c @@ -443,8 +443,11 @@ int utf8_fprintf(FILE *stream, const char *format, ...) strbuf_vaddf(buf,

[PATCH v2 2/2] i18n: mark OPTION_NUMBER (-NUM) for translation

Signed-off-by: Jiang Xin worldhello@gmail.com Signed-off-by: Nguyễn Thái Ngọc Duy pclo...@gmail.com --- parse-options.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/parse-options.c b/parse-options.c index cd029f..be916 100644 --- a/parse-options.c +++

Re: [PATCH v2 2/2] i18n: mark OPTION_NUMBER (-NUM) for translation

Jiang Xin worldhello@gmail.com writes: Signed-off-by: Jiang Xin worldhello@gmail.com Signed-off-by: Nguyễn Thái Ngọc Duy pclo...@gmail.com --- parse-options.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/parse-options.c b/parse-options.c index

Re: [PATCH v2 2/2] i18n: mark OPTION_NUMBER (-NUM) for translation

2013/2/6 Junio C Hamano gits...@pobox.com: I somehow suspect that this is going in a direction that makes this piece of code much less maintainable. Look at the entire function and see how many places you do fprintf on strings that are marked with _(). short_name and long_name are not

Re: [PATCH v2 2/2] i18n: mark OPTION_NUMBER (-NUM) for translation

Jiang Xin worldhello@gmail.com writes: 2013/2/6 Junio C Hamano gits...@pobox.com: I somehow suspect that this is going in a direction that makes this piece of code much less maintainable. Look at the entire function and see how many places you do fprintf on strings that are marked with

Re: [PATCH v2 2/2] i18n: mark OPTION_NUMBER (-NUM) for translation

2013/2/6 Junio C Hamano gits...@pobox.com: Jiang Xin worldhello@gmail.com writes: I agree, a helper named 'utf8_fprintf' in utf8.c is better. I will send a patch latter. Yeah, the idea of a helper function I agree with; I am not thrilled with the name utf8_fprintf() though. People use

Re: [PATCH v2 2/2] i18n: mark OPTION_NUMBER (-NUM) for translation

Jiang Xin worldhello@gmail.com writes: 2013/2/6 Junio C Hamano gits...@pobox.com: Jiang Xin worldhello@gmail.com writes: I agree, a helper named 'utf8_fprintf' in utf8.c is better. I will send a patch latter. Yeah, the idea of a helper function I agree with; I am not thrilled with