Re: [PATCH v2 2/2] mingw: fix mingw_open_append to work with named pipes

On 9/10/2018 6:00 PM, Junio C Hamano wrote: Johannes Sixt writes: +#define IS_SBS(ch) (((ch) == '/') || ((ch) == '\\')) I think you already have mingw_is_dir_sep() and its shorter alias is_dir_sep() available to you. good catch. thanks. +/* + * Does the pathname map to the local

Re: [PATCH v2 2/2] mingw: fix mingw_open_append to work with named pipes

Johannes Sixt writes: >> +#define IS_SBS(ch) (((ch) == '/') || ((ch) == '\\')) I think you already have mingw_is_dir_sep() and its shorter alias is_dir_sep() available to you. >> +/* >> + * Does the pathname map to the local named pipe filesystem? >> + * That is, does it have a "//./pipe/"

Re: [PATCH v2 2/2] mingw: fix mingw_open_append to work with named pipes

On 9/10/2018 3:45 PM, Johannes Sixt wrote: Am 10.09.18 um 19:05 schrieb Jeff Hostetler via GitGitGadget: diff --git a/compat/mingw.c b/compat/mingw.c index 858ca14a57..f87376b26a 100644 --- a/compat/mingw.c +++ b/compat/mingw.c @@ -341,6 +341,19 @@ int mingw_mkdir(const char *path, int mode)

Re: [PATCH v2 2/2] mingw: fix mingw_open_append to work with named pipes

Am 10.09.18 um 19:05 schrieb Jeff Hostetler via GitGitGadget: diff --git a/compat/mingw.c b/compat/mingw.c index 858ca14a57..f87376b26a 100644 --- a/compat/mingw.c +++ b/compat/mingw.c @@ -341,6 +341,19 @@ int mingw_mkdir(const char *path, int mode) return ret; } +/* + * Calling

[PATCH v2 2/2] mingw: fix mingw_open_append to work with named pipes

From: Jeff Hostetler Signed-off-by: Jeff Hostetler --- compat/mingw.c| 38 --- t/t0051-windows-named-pipe.sh | 2 +- 2 files changed, 36 insertions(+), 4 deletions(-) diff --git a/compat/mingw.c b/compat/mingw.c index 858ca14a57..f87376b26a