Jeff King p...@peff.net writes:
On Wed, Jan 22, 2014 at 08:06:42PM -0500, Jeff King wrote:
But I think there is a subtle problem. Here (and elsewhere) we use the
parsed value of 0 as a sentinel. I think that is OK for
--max-pack-size, where 0 is not a reasonable value. But git-repack(1)
These quantities can be larger than an int. Use ulong to express
them like the underlying pack-objects does, and also parse them with
the human-friendly unit suffixes.
Signed-off-by: Junio C Hamano gits...@pobox.com
---
builtin/repack.c | 12 ++--
1 file changed, 6 insertions(+), 6
On Wed, Jan 22, 2014 at 11:58:05AM -0800, Junio C Hamano wrote:
These quantities can be larger than an int. Use ulong to express
them like the underlying pack-objects does, and also parse them with
the human-friendly unit suffixes.
Hrm. I think that is a valid strategy, but...
- int
On Wed, Jan 22, 2014 at 08:06:42PM -0500, Jeff King wrote:
But I think there is a subtle problem. Here (and elsewhere) we use the
parsed value of 0 as a sentinel. I think that is OK for
--max-pack-size, where 0 is not a reasonable value. But git-repack(1)
says:
--window-memory=0 makes
4 matches
Mail list logo
