Re: [PATCH v2 2/5] update_unicode.sh: set UNICODE_DIR only once

2014-12-22 Thread Junio C Hamano
dev+...@drbeat.li writes: From: Beat Bolli dev+...@drbeat.li The value is the same on both uniset invocations, so Don't Repeat Yourself applies. Since we're in a subshell already, there's no need to unset UNICODE_DIR at the end. Strictly speaking, you are not introducing your own subshell

Re: [PATCH v2 2/5] update_unicode.sh: set UNICODE_DIR only once

2014-12-22 Thread Beat Bolli
On 22.12.14 19:02, Junio C Hamano wrote: dev+...@drbeat.li writes: From: Beat Bolli dev+...@drbeat.li The value is the same on both uniset invocations, so Don't Repeat Yourself applies. Since we're in a subshell already, there's no need to unset UNICODE_DIR at the end. Strictly

[PATCH v2 2/5] update_unicode.sh: set UNICODE_DIR only once

2014-12-19 Thread dev+git
From: Beat Bolli dev+...@drbeat.li The value is the same on both uniset invocations, so Don't Repeat Yourself applies. Since we're in a subshell already, there's no need to unset UNICODE_DIR at the end. Signed-off-by: Beat Bolli dev+...@drbeat.li --- update_unicode.sh | 5 +++-- 1 file

[PATCH v2 2/5] update_unicode.sh: set UNICODE_DIR only once

2014-12-19 Thread dev+git
From: Beat Bolli dev+...@drbeat.li The value is the same on both uniset invocations, so Don't Repeat Yourself applies. Since we're in a subshell already, there's no need to unset UNICODE_DIR at the end. Signed-off-by: Beat Bolli dev+...@drbeat.li --- update_unicode.sh | 5 +++-- 1 file