Re: [PATCH v2 3/6] update_unicode.sh: pin the uniset repo to a known good commit

2016-12-15 Thread Junio C Hamano
Dennis Kaarsemaker writes: > On Wed, 2016-12-14 at 00:31 +0100, Beat Bolli wrote: >> +   ( cd uniset && git checkout 4b186196dd ) > > Micronit, but this is perhaps better written as > > git -C uniset checkout 4b186196dd > > to avoid the subshell and cd. > > D. In the

Re: [PATCH v2 3/6] update_unicode.sh: pin the uniset repo to a known good commit

2016-12-15 Thread Dennis Kaarsemaker
On Wed, 2016-12-14 at 00:31 +0100, Beat Bolli wrote: > +   ( cd uniset && git checkout 4b186196dd ) Micronit, but this is perhaps better written as git -C uniset checkout 4b186196dd to avoid the subshell and cd. D.

[PATCH v2 3/6] update_unicode.sh: pin the uniset repo to a known good commit

2016-12-13 Thread Beat Bolli
The uniset upstream has added more commits that for example change the hexadecimal output in '--32' mode to decimal. Let's pin the repo to a commit that still outputs the width tables in the format we want. Signed-off-by: Beat Bolli ---