Re: [PATCH v3] http.postbuffer: allow full range of ssize_t values

2017-04-06 Thread Jeff King
On Thu, Apr 06, 2017 at 07:24:54PM +0200, Christian Couder wrote: > > That would at least tell you if the problem is the chunked encoding, or > > if it's related to the size. > > The above commands work for me using gitlab.com and the log shows: > > Send header, 000309 bytes (0x0135) >

Re: [PATCH v3] http.postbuffer: allow full range of ssize_t values

2017-04-06 Thread Christian Couder
On Tue, Apr 4, 2017 at 10:40 PM, Jeff King wrote: > On Tue, Apr 04, 2017 at 06:42:23PM +, David Turner wrote: > >> > What does it look like when it fails? What does GIT_TRACE_CURL look like >> > (or >> > GIT_CURL_VERBOSE if your client is older, but remember to sanitize any

Re: [PATCH v3] http.postbuffer: allow full range of ssize_t values

2017-04-04 Thread Jeff King
On Tue, Apr 04, 2017 at 06:42:23PM +, David Turner wrote: > > What does it look like when it fails? What does GIT_TRACE_CURL look like (or > > GIT_CURL_VERBOSE if your client is older, but remember to sanitize any auth > > lines)? > > Unfortunately, we've already worked around the problem by

RE: [PATCH v3] http.postbuffer: allow full range of ssize_t values

2017-04-04 Thread David Turner
> -Original Message- > From: Jeff King [mailto:p...@peff.net] > Sent: Monday, April 3, 2017 10:02 PM > To: David Turner <david.tur...@twosigma.com> > Cc: git@vger.kernel.org > Subject: Re: [PATCH v3] http.postbuffer: allow full range of ssize_t values > >

Re: [PATCH v3] http.postbuffer: allow full range of ssize_t values

2017-04-03 Thread Jeff King
On Mon, Apr 03, 2017 at 05:03:49PM +, David Turner wrote: > > > Unfortunately, in order to push some large repos, the http postbuffer > > > must sometimes exceed two gigabytes. On a 64-bit system, this is OK: > > > we just malloc a larger buffer. > > > > I'm still not sure why a 2GB

RE: [PATCH v3] http.postbuffer: allow full range of ssize_t values

2017-04-03 Thread David Turner
> -Original Message- > From: Jeff King [mailto:p...@peff.net] > Sent: Saturday, April 1, 2017 2:01 AM > To: David Turner <david.tur...@twosigma.com> > Cc: git@vger.kernel.org > Subject: Re: [PATCH v3] http.postbuffer: allow full range of ssize_t values > >

Re: [PATCH v3] http.postbuffer: allow full range of ssize_t values

2017-04-01 Thread Junio C Hamano
Jeff King writes: > On Fri, Mar 31, 2017 at 01:26:31PM -0400, David Turner wrote: > >> Unfortunately, in order to push some large repos, the http postbuffer >> must sometimes exceed two gigabytes. On a 64-bit system, this is OK: >> we just malloc a larger buffer. > > I'm still

Re: [PATCH v3] http.postbuffer: allow full range of ssize_t values

2017-04-01 Thread Jeff King
On Fri, Mar 31, 2017 at 01:26:31PM -0400, David Turner wrote: > Unfortunately, in order to push some large repos, the http postbuffer > must sometimes exceed two gigabytes. On a 64-bit system, this is OK: > we just malloc a larger buffer. I'm still not sure why a 2GB post-buffer is necessary.

Re: [PATCH v3] http.postbuffer: allow full range of ssize_t values

2017-03-31 Thread Junio C Hamano
David Turner writes: > +static int git_parse_ssize_t(const char *value, ssize_t *ret) > +{ > + ssize_t tmp; > + if (!git_parse_signed(value, , > maximum_signed_value_of_type(ssize_t))) > + return 0; > + *ret = tmp; > + return 1; > +} > + >

[PATCH v3] http.postbuffer: allow full range of ssize_t values

2017-03-31 Thread David Turner
Unfortunately, in order to push some large repos, the http postbuffer must sometimes exceed two gigabytes. On a 64-bit system, this is OK: we just malloc a larger buffer. Signed-off-by: David Turner --- This version fixes the definition of git_parse_ssize_t to return int.