Re: [PATCH v3 0/7] grep.c: teach --column to 'git-grep(1)'

2018-06-26 Thread Junio C Hamano
Taylor Blau writes: > On Mon, Jun 25, 2018 at 02:43:50PM -0400, Jeff King wrote: >> On Fri, Jun 22, 2018 at 10:49:26AM -0500, Taylor Blau wrote: >> > Since the last time, only a couple of things have changed at Peff's >> > suggestions in [1]. The changes are summarized here, and an inter-diff >>

Re: [PATCH v3 0/7] grep.c: teach --column to 'git-grep(1)'

2018-06-25 Thread Taylor Blau
On Mon, Jun 25, 2018 at 02:43:50PM -0400, Jeff King wrote: > On Fri, Jun 22, 2018 at 10:49:26AM -0500, Taylor Blau wrote: > > Since the last time, only a couple of things have changed at Peff's > > suggestions in [1]. The changes are summarized here, and an inter-diff > > is available below: > > >

Re: [PATCH v3 0/7] grep.c: teach --column to 'git-grep(1)'

2018-06-25 Thread Jeff King
On Fri, Jun 22, 2018 at 10:49:26AM -0500, Taylor Blau wrote: > Attached is my third--anticipate the final--re-roll of my series to > teach 'git grep --column'. You know when you say that it jinxes it, right? :) > Since the last time, only a couple of things have changed at Peff's > suggestions

[PATCH v3 0/7] grep.c: teach --column to 'git-grep(1)'

2018-06-22 Thread Taylor Blau
Hi, Attached is my third--anticipate the final--re-roll of my series to teach 'git grep --column'. Since the last time, only a couple of things have changed at Peff's suggestions in [1]. The changes are summarized here, and an inter-diff is available below: - Change "%zu" to PRIuMAX (and an