Re: [PATCH v3 1/3] Add Travis CI support

2015-10-15 Thread Lars Schneider
On 15 Oct 2015, at 10:12, Matthieu Moy wrote: > Lars Schneider writes: > >> I was reluctant to this because I feared problems. Especially while >> running tests in parallel. > > Isn't the point of using a CI tool to notice problems? ;-)

Re: [PATCH v3 1/3] Add Travis CI support

2015-10-15 Thread Johannes Schindelin
Hi, On Thu, 15 Oct 2015, Matthieu Moy wrote: > Lars Schneider writes: > > > I was reluctant to this because I feared problems. Especially while > > running tests in parallel. > > Isn't the point of using a CI tool to notice problems? ;-) > > More seriously, running

Re: [PATCH v3 1/3] Add Travis CI support

2015-10-15 Thread Jean-Noël Avila
Le 15/10/2015 00:52, Lars Schneider a écrit : > On 12 Oct 2015, at 22:20, Matthieu Moy wrote: > >> larsxschnei...@gmail.com writes: >> >>> --- /dev/null >>> +++ b/.travis.yml >>> @@ -0,0 +1,46 @@ >>> +language: c >>> + >>> +os: >>> + - linux >>> + - osx >>> + >>>

Re: [PATCH v3 1/3] Add Travis CI support

2015-10-15 Thread Matthieu Moy
Lars Schneider writes: > I would like to get rid of the "sudo" calls, too. Unfortunately I > wasn't able to achieve this so far because these packages are not > white listed on Travis CI (see Jean-Noël answer in this thread). I think this would deserve a mention in the

Re: [PATCH v3 1/3] Add Travis CI support

2015-10-15 Thread Lars Schneider
On 13 Oct 2015, at 12:32, Jean-Noël Avila wrote: > Le 11/10/2015 19:55, larsxschnei...@gmail.com a écrit : >> + >> +before_script: make >> + >> +script: make --quiet test > > Travis can be used in container mode but that would need getting rid of > "sudo" command and only

Re: [PATCH v3 1/3] Add Travis CI support

2015-10-15 Thread Matthieu Moy
Lars Schneider writes: > I was reluctant to this because I feared problems. Especially while > running tests in parallel. Isn't the point of using a CI tool to notice problems? ;-) More seriously, running tests in parallel shouldn't be a problem since each test runs

Re: [PATCH v3 1/3] Add Travis CI support

2015-10-15 Thread Matthieu Moy
Johannes Schindelin writes: > On Thu, 15 Oct 2015, Matthieu Moy wrote: > >> Since the tests are essentially IO-bound and not CPU-bound, it may even >> make sense to use -j3 here. > > I would like to caution against overloading Travis. They are really nice > to us, we

Re: [PATCH v3 1/3] Add Travis CI support

2015-10-14 Thread Lars Schneider
On 12 Oct 2015, at 22:20, Matthieu Moy wrote: > larsxschnei...@gmail.com writes: > >> --- /dev/null >> +++ b/.travis.yml >> @@ -0,0 +1,46 @@ >> +language: c >> + >> +os: >> + - linux >> + - osx >> + >> +compiler: >> + - clang >> + - gcc >> + >>

Re: [PATCH v3 1/3] Add Travis CI support

2015-10-13 Thread Jean-Noël Avila
Le 11/10/2015 19:55, larsxschnei...@gmail.com a écrit : > + > +before_script: make > + > +script: make --quiet test Travis can be used in container mode but that would need getting rid of "sudo" command and only installing from white-listed sources

Re: [PATCH v3 1/3] Add Travis CI support

2015-10-12 Thread Sebastian Schuberth
On 10/11/2015 19:55, larsxschnei...@gmail.com wrote: + sudo apt-get update -qq + sudo apt-get install -y apt-transport-https + sudo apt-get install perforce-server git-lfs Why no "-y" also in this line, or append these to the previous line? Or maybe even better, like [1] does,

Re: [PATCH v3 1/3] Add Travis CI support

2015-10-12 Thread Junio C Hamano
Sebastian Schuberth writes: > Semantically, it does not seem correct to me that configuarion goes to > the install step. As "make test" will build git anyway, I'd instead > propose to get rid of "install" and just say: > > before_script: make configure && ./configure > >

Re: [PATCH v3 1/3] Add Travis CI support

2015-10-12 Thread Lars Schneider
>> + brew_force_set_latest_binary_hash () { >> +FORUMULA=$1 > > Is this spelling intentional or is it a misspelling of "formula"? This is a misspelling. I will fix it. Thanks, Lars -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to

Re: [PATCH v3 1/3] Add Travis CI support

2015-10-12 Thread Lars Schneider
On 12 Oct 2015, at 01:05, Sebastian Schuberth wrote: > On 10/11/2015 19:55, larsxschnei...@gmail.com wrote: > >> + sudo apt-get update -qq >> + sudo apt-get install -y apt-transport-https >> + sudo apt-get install perforce-server git-lfs > > Why no "-y"

Re: [PATCH v3 1/3] Add Travis CI support

2015-10-12 Thread Sebastian Schuberth
On Mon, Oct 12, 2015 at 6:02 PM, Junio C Hamano wrote: >> Semantically, it does not seem correct to me that configuarion goes to >> the install step. As "make test" will build git anyway, I'd instead >> propose to get rid of "install" and just say: >> >> before_script: make

Re: [PATCH v3 1/3] Add Travis CI support

2015-10-12 Thread Lars Schneider
On 12 Oct 2015, at 12:37, Sebastian Schuberth wrote: > On Mon, Oct 12, 2015 at 7:12 PM, Lars Schneider > wrote: > +install: make configure && ./configure + +before_script: make + +script: make --quiet test >>> >>>

Re: [PATCH v3 1/3] Add Travis CI support

2015-10-12 Thread Sebastian Schuberth
On Mon, Oct 12, 2015 at 9:43 PM, Lars Schneider wrote: >> Reading through Travis' docs [3] again, "before_script" is documented >> to "return a non-zero exit code, the build is errored and stops >> immediately", while "script" is documented as "returns a non-zero exit

Re: [PATCH v3 1/3] Add Travis CI support

2015-10-12 Thread Matthieu Moy
larsxschnei...@gmail.com writes: > --- /dev/null > +++ b/.travis.yml > @@ -0,0 +1,46 @@ > +language: c > + > +os: > + - linux > + - osx > + > +compiler: > + - clang > + - gcc > + > +before_install: > + - > > +export GIT_TEST_OPTS=" --quiet"; > +case "${TRAVIS_OS_NAME:-linux}" in > +

Re: [PATCH v3 1/3] Add Travis CI support

2015-10-12 Thread Sebastian Schuberth
On Mon, Oct 12, 2015 at 7:12 PM, Lars Schneider wrote: >>> +install: make configure && ./configure >>> + >>> +before_script: make >>> + >>> +script: make --quiet test >> >> Semantically, it does not seem correct to me that configuarion goes to the >> install step. As

Re: [PATCH v3 1/3] Add Travis CI support

2015-10-12 Thread Lars Schneider
On 12 Oct 2015, at 09:02, Junio C Hamano wrote: > Sebastian Schuberth writes: > >> Semantically, it does not seem correct to me that configuarion goes to >> the install step. As "make test" will build git anyway, I'd instead >> propose to get rid of

Re: [PATCH v3 1/3] Add Travis CI support

2015-10-12 Thread Matthieu Moy
Lars Schneider writes: > {Linux | OSX} * {gcc | clang} * {Default, NO_PTHREAD, NO_CURL, NO_OPENSSL, > NO_MMAP, NO_IPV6, NO_PERL} Another option would be to have a single "NO_*" build, that would activate all NO_PTHREAD, NO_CURL, NO_OPENSSL, NO_MMAP, NO_IPV6, NO_PERL

[PATCH v3 1/3] Add Travis CI support

2015-10-11 Thread larsxschneider
From: Lars Schneider The tests are currently executed on "Ubuntu 12.04 LTS Server Edition 64 bit" and on "OS X Mavericks" using gcc and clang. Perforce and Git-LFS are installed and therefore available for the respective tests. Signed-off-by: Lars Schneider

Re: [PATCH v3 1/3] Add Travis CI support

2015-10-11 Thread Eric Sunshine
On Sun, Oct 11, 2015 at 1:55 PM, wrote: > From: Lars Schneider > > The tests are currently executed on "Ubuntu 12.04 LTS Server Edition > 64 bit" and on "OS X Mavericks" using gcc and clang. > > Perforce and Git-LFS are installed and therefore