Re: [PATCH v3 2/4] unpack-trees: optimize walking same trees with cache-tree

2018-08-10 Thread Elijah Newren
On Fri, Aug 10, 2018 at 9:29 AM Duy Nguyen wrote: > On Wed, Aug 8, 2018 at 8:23 PM Elijah Newren wrote: > > > +* cache-tree would be invalidated and we would never get here > > > +* in the first place. > > > +*/ > > > + for (i = 0; i < nr_entries; i++) { > > > +

Re: [PATCH v3 2/4] unpack-trees: optimize walking same trees with cache-tree

2018-08-10 Thread Duy Nguyen
On Wed, Aug 8, 2018 at 8:23 PM Elijah Newren wrote: > > diff --git a/unpack-trees.c b/unpack-trees.c > > index a32ddee159..ba3d2e947e 100644 > > --- a/unpack-trees.c > > +++ b/unpack-trees.c > > @@ -644,6 +644,102 @@ static inline int are_same_oid(struct name_entry > > *name_j, struct name_entry

Re: [PATCH v3 2/4] unpack-trees: optimize walking same trees with cache-tree

2018-08-08 Thread Elijah Newren
On Fri, Aug 3, 2018 at 10:39 PM Nguyễn Thái Ngọc Duy wrote: > From: Duy Nguyen > > In order to merge one or many trees with the index, unpack-trees code > walks multiple trees in parallel with the index and performs n-way > merge. If we find out at start of a directory that all trees are the >

[PATCH v3 2/4] unpack-trees: optimize walking same trees with cache-tree

2018-08-03 Thread Nguyễn Thái Ngọc Duy
From: Duy Nguyen In order to merge one or many trees with the index, unpack-trees code walks multiple trees in parallel with the index and performs n-way merge. If we find out at start of a directory that all trees are the same (by comparing OID) and cache-tree happens to be available for that