Re: [PATCH v4 3/3] git: submodule honor -c credential.* from command line

2016-02-26 Thread Jacob Keller
On Fri, Feb 26, 2016 at 2:20 PM, Jacob Keller wrote: >> that is slightly more verbose, but it does let us keep the main body >> inside single-quotes, without restoring to confusing backslash escaping. >> > > I think I prefer the double quotes myself but will use this if

Re: [PATCH v4 3/3] git: submodule honor -c credential.* from command line

2016-02-26 Thread Jacob Keller
On Fri, Feb 26, 2016 at 2:05 PM, Jeff King wrote: > On Fri, Feb 26, 2016 at 11:18:48AM -0800, Jacob Keller wrote: > >> +test_expect_success 'sanitize-config keeps credential.helper' " >> + git -c credential.helper=helper submodule--helper sanitize-config >> >actual && >> +

Re: [PATCH v4 3/3] git: submodule honor -c credential.* from command line

2016-02-26 Thread Jeff King
On Fri, Feb 26, 2016 at 11:18:48AM -0800, Jacob Keller wrote: > +test_expect_success 'sanitize-config keeps credential.helper' " > + git -c credential.helper=helper submodule--helper sanitize-config > >actual && > + cat >expect <<-EOF && > + 'credential.helper=helper' > + EOF > +

[PATCH v4 3/3] git: submodule honor -c credential.* from command line

2016-02-26 Thread Jacob Keller
From: Jacob Keller Due to the way that the git-submodule code works, it clears all local git environment variables before entering submodules. This is normally a good thing since we want to clear settings such as GIT_WORKTREE and other variables which would affect the