Re: [PATCH v5] http.postbuffer: allow full range of ssize_t values

2017-04-11 Thread Lars Schneider
> On 04 Apr 2017, at 17:20, Ramsay Jones wrote: > > > > On 04/04/17 00:53, David Turner wrote: >> Unfortunately, in order to push some large repos, the http postbuffer >> must sometimes exceed two gigabytes. On a 64-bit system, this is OK: >> we just malloc a larger buffer. >> >> This means

Re: [PATCH v5] http.postbuffer: allow full range of ssize_t values

2017-04-04 Thread Ramsay Jones
On 04/04/17 00:53, David Turner wrote: > Unfortunately, in order to push some large repos, the http postbuffer > must sometimes exceed two gigabytes. On a 64-bit system, this is OK: > we just malloc a larger buffer. > > This means that we need to use CURLOPT_POSTFIELDSIZE_LARGE to set the > buf

Re: [PATCH v5] http.postbuffer: allow full range of ssize_t values

2017-04-03 Thread Jeff King
On Mon, Apr 03, 2017 at 06:32:10PM -0700, Jonathan Nieder wrote: > David Turner wrote: > > > This means that we need to use CURLOPT_POSTFIELDSIZE_LARGE to set the > > buffer size. > > Neat. > > For completeness, it's useful to know this was added in curl 7.11.1, > which is old enough for us to

Re: [PATCH v5] http.postbuffer: allow full range of ssize_t values

2017-04-03 Thread Jonathan Nieder
David Turner wrote: > This means that we need to use CURLOPT_POSTFIELDSIZE_LARGE to set the > buffer size. Neat. For completeness, it's useful to know this was added in curl 7.11.1, which is old enough for us to be able to count on users having it (in fact it was released >10 years ago). [...]

[PATCH v5] http.postbuffer: allow full range of ssize_t values

2017-04-03 Thread David Turner
Unfortunately, in order to push some large repos, the http postbuffer must sometimes exceed two gigabytes. On a 64-bit system, this is OK: we just malloc a larger buffer. This means that we need to use CURLOPT_POSTFIELDSIZE_LARGE to set the buffer size. Signed-off-by: David Turner --- V5 addre