Re: [PATCH v5 1/3] sumodule--helper: fix submodule--helper clone usage and check argc count

On Mon, Feb 29, 2016 at 11:44 AM, Junio C Hamano wrote: > Jacob Keller writes: >> That actually is required because otherwise adding a check for argc >> would break the things. I could split them and do this first and then >> check for argc if you

Re: [PATCH v5 1/3] sumodule--helper: fix submodule--helper clone usage and check argc count

Jacob Keller writes: >> This does make sense but it is an unrelated fix. Perhaps split this >> patch into two? > > That actually is required because otherwise adding a check for argc > would break the things. I could split them and do this first and then > check for argc

Re: [PATCH v5 1/3] sumodule--helper: fix submodule--helper clone usage and check argc count

On Mon, Feb 29, 2016 at 9:49 AM, Junio C Hamano wrote: > Jacob Keller writes: >> Fix the usage description to match implementation. Add an argc check to >> enforce no extra arguments. > > The above sounds very sensible. > Right. >> Fix a bug in the

Re: [PATCH v5 1/3] sumodule--helper: fix submodule--helper clone usage and check argc count

Jacob Keller writes: > From: Jacob Keller > > git submodule--helper clone usage specified that paths come after the -- > as a sequence. However, the actual implementation does not, and requires > only a single path passed in via --path. In

[PATCH v5 1/3] sumodule--helper: fix submodule--helper clone usage and check argc count

From: Jacob Keller git submodule--helper clone usage specified that paths come after the -- as a sequence. However, the actual implementation does not, and requires only a single path passed in via --path. In addition, argc was unchecked. (allowing arbitrary extra