Re: [PATCH v5 3/3] git: submodule honor -c credential.* from command line

2016-02-29 Thread Jacob Keller
On Mon, Feb 29, 2016 at 11:47 AM, Junio C Hamano wrote: > I was talking about the "not even an equal sign" true, i.e. > > $ git -c random.what -c random.false=no -c random.true=yes \ > config --bool --get-regexp 'random.*' > random.what true > random.false

Re: [PATCH v5 3/3] git: submodule honor -c credential.* from command line

2016-02-29 Thread Junio C Hamano
Jacob Keller writes: > On Mon, Feb 29, 2016 at 10:20 AM, Junio C Hamano wrote: >> Jacob Keller writes: >> >>> +static int sanitize_submodule_config(const char *var, const char *value, >>> void *data) >>> +{ >>> + struct

Re: [PATCH v5 3/3] git: submodule honor -c credential.* from command line

2016-02-29 Thread Jacob Keller
On Mon, Feb 29, 2016 at 10:20 AM, Junio C Hamano wrote: > Jacob Keller writes: > >> +static int sanitize_submodule_config(const char *var, const char *value, >> void *data) >> +{ >> + struct strbuf quoted = STRBUF_INIT; >> + struct strbuf

Re: [PATCH v5 3/3] git: submodule honor -c credential.* from command line

2016-02-29 Thread Junio C Hamano
Jacob Keller writes: > +static int sanitize_submodule_config(const char *var, const char *value, > void *data) > +{ > + struct strbuf quoted = STRBUF_INIT; > + struct strbuf *out = data; > + > + if (submodule_config_ok(var)) { > + if (out->len)

[PATCH v5 3/3] git: submodule honor -c credential.* from command line

2016-02-26 Thread Jacob Keller
From: Jacob Keller Due to the way that the git-submodule code works, it clears all local git environment variables before entering submodules. This is normally a good thing since we want to clear settings such as GIT_WORKTREE and other variables which would affect the