Re: [PATCH v5 3/4] test-strcmp-offset: created test for strcmp_offset

On 4/6/2017 4:20 PM, René Scharfe wrote: Am 05.04.2017 um 19:38 schrieb g...@jeffhostetler.com: diff --git a/t/helper/test-strcmp-offset.c b/t/helper/test-strcmp-offset.c new file mode 100644 index 000..fe01318 --- /dev/null +++ b/t/helper/test-strcmp-offset.c @@ -0,0 +1,64 @@ +#include

Re: [PATCH v5 3/4] test-strcmp-offset: created test for strcmp_offset

Am 05.04.2017 um 19:38 schrieb g...@jeffhostetler.com: diff --git a/t/helper/test-strcmp-offset.c b/t/helper/test-strcmp-offset.c new file mode 100644 index 000..fe01318 --- /dev/null +++ b/t/helper/test-strcmp-offset.c @@ -0,0 +1,64 @@ +#include "cache.h" + +struct test_data { + const

Re: [PATCH v5 3/4] test-strcmp-offset: created test for strcmp_offset

On 4/6/2017 4:21 AM, Johannes Schindelin wrote: Hi Gábor, On Thu, 6 Apr 2017, SZEDER Gábor wrote: I think this patch should be squashed into the previous commit; I don't see any reason why the tests should be added in a different commit than the function they are testing. Will do. I

Re: [PATCH v5 3/4] test-strcmp-offset: created test for strcmp_offset

Hi Gábor, On Thu, 6 Apr 2017, SZEDER Gábor wrote: > I think this patch should be squashed into the previous commit; I > don't see any reason why the tests should be added in a different > commit than the function they are testing. I am of two minds there. In some cases, the newly added test

Re: [PATCH v5 3/4] test-strcmp-offset: created test for strcmp_offset

I think this patch should be squashed into the previous commit; I don't see any reason why the tests should be added in a different commit than the function they are testing. However... > Signed-off-by: Jeff Hostetler > --- > Makefile | 1 + >

[PATCH v5 3/4] test-strcmp-offset: created test for strcmp_offset

From: Jeff Hostetler Signed-off-by: Jeff Hostetler --- Makefile | 1 + t/helper/.gitignore | 1 + t/helper/test-strcmp-offset.c | 64 +++ t/t0065-strcmp-offset.sh | 11