Re: [PATCHv3 4/4] clone: use free_refspec() to free refspec list

2017-05-23 Thread SZEDER Gábor
On Tue, May 23, 2017 at 9:38 AM, Junio C Hamano wrote: > I was sifting entries in the draft "What's cooking" report to find > topics to merge to 'next'. I read the series over and as Peff said > in his <20170515224615.f6hnnfngwpier...@sigill.intra.peff.net>, I > think the series overall is good.

Re: [PATCHv3 4/4] clone: use free_refspec() to free refspec list

2017-05-23 Thread Jeff King
On Tue, May 23, 2017 at 04:38:07PM +0900, Junio C Hamano wrote: > > First, the unchanged commit message is now (i.e. by using the parsed > > refspecs returned by remote_get()) completely outdated. > > Second, while it properly frees those refspecs, i.e. the array and all > > its string fields, it

Re: [PATCHv3 4/4] clone: use free_refspec() to free refspec list

2017-05-23 Thread Junio C Hamano
SZEDER Gábor writes: > On Mon, May 15, 2017 at 1:05 PM, SZEDER Gábor wrote: >> From: Jeff King >> >> Using free() on a refspec was always leaky, as its string >> fields also need freed. But it became more so when ad00f128d >> (clone: respect configured fetch respecs during initial >> fetch, 201

Re: [PATCHv3 4/4] clone: use free_refspec() to free refspec list

2017-05-15 Thread Jeff King
On Mon, May 15, 2017 at 01:29:07PM +0200, SZEDER Gábor wrote: > On Mon, May 15, 2017 at 1:05 PM, SZEDER Gábor wrote: > > From: Jeff King > > > > Using free() on a refspec was always leaky, as its string > > fields also need freed. But it became more so when ad00f128d > > (clone: respect configur

Re: [PATCHv3 4/4] clone: use free_refspec() to free refspec list

2017-05-15 Thread SZEDER Gábor
On Mon, May 15, 2017 at 1:05 PM, SZEDER Gábor wrote: > From: Jeff King > > Using free() on a refspec was always leaky, as its string > fields also need freed. But it became more so when ad00f128d > (clone: respect configured fetch respecs during initial > fetch, 2016-03-30) taught clone to create

[PATCHv3 4/4] clone: use free_refspec() to free refspec list

2017-05-15 Thread SZEDER Gábor
From: Jeff King Using free() on a refspec was always leaky, as its string fields also need freed. But it became more so when ad00f128d (clone: respect configured fetch respecs during initial fetch, 2016-03-30) taught clone to create a list of refspecs, each of which need to be freed. [sg: adjust