Re: [RFC] Add way to make Git credentials accessible from clean/smudge filter

2016-11-12 Thread Lars Schneider
> On 11 Nov 2016, at 21:27, Jeff King wrote: > > On Fri, Nov 11, 2016 at 09:02:52PM +0100, Dennis Kaarsemaker wrote: > Are you sure about that? If I do: echo url=https://example.com/repo.git | git credential fill I get prompted for a username and

Re: [RFC] Add way to make Git credentials accessible from clean/smudge filter

2016-11-11 Thread Jeff King
On Fri, Nov 11, 2016 at 09:02:52PM +0100, Dennis Kaarsemaker wrote: > > > Are you sure about that? If I do: > > > > > > echo url=https://example.com/repo.git | > > > git credential fill > > > > > > I get prompted for a username and password. > > > > > > Hm.. either I don't understand you or

Re: [RFC] Add way to make Git credentials accessible from clean/smudge filter

2016-11-11 Thread Dennis Kaarsemaker
On Fri, 2016-11-11 at 10:40 +0100, Lars Schneider wrote: > On 11 Nov 2016, at 10:31, Jeff King wrote: > > > On Fri, Nov 11, 2016 at 10:28:56AM +0100, Lars Schneider wrote: > > > > > > Yeah, that is the solution I was going to suggest. The credentials are > > > > totally

Re: [RFC] Add way to make Git credentials accessible from clean/smudge filter

2016-11-11 Thread Lars Schneider
On 11 Nov 2016, at 10:31, Jeff King wrote: > On Fri, Nov 11, 2016 at 10:28:56AM +0100, Lars Schneider wrote: > >>> Yeah, that is the solution I was going to suggest. The credentials are >>> totally orthogonal to the filters, and I would rather not shove them >>> into the

Re: [RFC] Add way to make Git credentials accessible from clean/smudge filter

2016-11-11 Thread Jeff King
On Fri, Nov 11, 2016 at 10:28:56AM +0100, Lars Schneider wrote: > > Yeah, that is the solution I was going to suggest. The credentials are > > totally orthogonal to the filters, and I would rather not shove them > > into the protocol. It's an extra process, but with the new multi-use > > smudge

Re: [RFC] Add way to make Git credentials accessible from clean/smudge filter

2016-11-11 Thread Lars Schneider
On 10 Nov 2016, at 17:08, Jeff King wrote: > On Thu, Nov 10, 2016 at 01:10:17PM +0100, Matthieu Moy wrote: > >> Lars Schneider writes: >> >>> I haven't looked at an implemenation approach at all. I wonder if this could >>> be OK from a conceptional

Re: [RFC] Add way to make Git credentials accessible from clean/smudge filter

2016-11-10 Thread Jeff King
On Thu, Nov 10, 2016 at 01:10:17PM +0100, Matthieu Moy wrote: > Lars Schneider writes: > > > I haven't looked at an implemenation approach at all. I wonder if this could > > be OK from a conceptional point of view or if there are obvious security > > problems that I

Re: [RFC] Add way to make Git credentials accessible from clean/smudge filter

2016-11-10 Thread Matthieu Moy
Lars Schneider writes: > I haven't looked at an implemenation approach at all. I wonder if this could > be OK from a conceptional point of view or if there are obvious security > problems that I am missing. Did you consider just running "git credential" from the

[RFC] Add way to make Git credentials accessible from clean/smudge filter

2016-11-10 Thread Lars Schneider
Hi, we just implemented the first "real-world" user of the new clean/smudge "filter protocol" interface (see "convert: add filter..process option" edcc858 for details) and the results are fantastic. Filtering 12,000 files in my artificial test repo is more than 60x faster (depending on the