Re: [RFC 0/3] imap-send curl tunnelling support

On Thu, 24 Aug 2017, Jeff King wrote: Oh good. While I have you here, have you given any thought to a curl handle that has two half-duplex file descriptors, rather than a single full-duplex socket? That would let us tunnel over pipes rather than worrying about the portability of socketpair().

Re: [RFC 0/3] imap-send curl tunnelling support

On Thu, Aug 24, 2017 at 04:02:19PM +0200, Daniel Stenberg wrote: > On Thu, 24 Aug 2017, Jeff King wrote: > > > > I opened a bug upstream and they already fixed this. > > > https://github.com/curl/curl/pull/1820 > > > > Cool! That's much faster than I had expected. :) > > Your wish is our

Re: [RFC 0/3] imap-send curl tunnelling support

On Thu, Aug 24, 2017 at 04:15:04PM +0200, Nicolas Morey-Chaisemartin wrote: > >> 1) There does not seem to be an easy/clean workaround for the lack of > >> socketpair on windows. > >> Fidling with a loopback AF_UNIX?AF_LOCAL socket should work but it > >> means creating a socket file somewhere

Re: [RFC 0/3] imap-send curl tunnelling support

Le 24/08/2017 à 15:53, Jeff King a écrit : > On Thu, Aug 24, 2017 at 10:00:47AM +0200, Nicolas Morey-Chaisemartin wrote: > >>> Yes, I agree. I was hoping when we started this discussion that we were >>> more ready to switch to curl-by-default. But sadly, that isn't close to >>> being the case.

Re: [RFC 0/3] imap-send curl tunnelling support

On Thu, 24 Aug 2017, Jeff King wrote: I opened a bug upstream and they already fixed this. https://github.com/curl/curl/pull/1820 Cool! That's much faster than I had expected. :) Your wish is our command! =) -- / daniel.haxx.se (who landed the IMAP PREAUTH fix in curl)

Re: [RFC 0/3] imap-send curl tunnelling support

On Thu, Aug 24, 2017 at 10:00:47AM +0200, Nicolas Morey-Chaisemartin wrote: > > Yes, I agree. I was hoping when we started this discussion that we were > > more ready to switch to curl-by-default. But sadly, that isn't close to > > being the case. But hopefully we can at least end up with logic

[RFC 0/3] imap-send curl tunnelling support

Le 23/08/2017 à 23:43, Jeff King a écrit : > On Mon, Aug 21, 2017 at 09:34:19AM +0200, Nicolas Morey-Chaisemartin wrote: > It appears curl do not support the PREAUTH tag. >>> Too bad. IMHO preauth is the main reason to use a tunnel in the first >>> place. >> It shouldn't be too hard to add

Re: [RFC 0/3] imap-send curl tunnelling support

Hi Hannes, On Tue, 22 Aug 2017, Johannes Sixt wrote: > Am 21.08.2017 um 09:27 schrieb Nicolas Morey-Chaisemartin: > > (Sent a reply from my phone while out of town but couldn't find it so here > > it is again) > > > > It's available on my github: > >

Re: [RFC 0/3] imap-send curl tunnelling support

On Mon, Aug 21, 2017 at 09:34:19AM +0200, Nicolas Morey-Chaisemartin wrote: > >> It appears curl do not support the PREAUTH tag. > > Too bad. IMHO preauth is the main reason to use a tunnel in the first > > place. > > It shouldn't be too hard to add support for this in curl. > If it's the main

Re: [RFC 0/3] imap-send curl tunnelling support

This was sadly kind of expected... I need to look for another way to handle this on Windows. Thanks for the test Nicolas Le 22/08/2017 à 19:10, Johannes Sixt a écrit : > Am 21.08.2017 um 09:27 schrieb Nicolas Morey-Chaisemartin: >> (Sent a reply from my phone while out of town but couldn't find

Re: [RFC 0/3] imap-send curl tunnelling support

Am 21.08.2017 um 09:27 schrieb Nicolas Morey-Chaisemartin: (Sent a reply from my phone while out of town but couldn't find it so here it is again) It's available on my github: https://github.com/nmorey/git/tree/dev/curl-tunnel The series had been stlighly changed since the patch were posted,

Re: [RFC 0/3] imap-send curl tunnelling support

Le 16/08/2017 à 10:34, Jeff King a écrit : > On Wed, Aug 09, 2017 at 04:43:26PM +0200, Nicolas Morey-Chaisemartin wrote: > >> I have a few doubt on patch #2: >> - is socketpair working on all git supported system (windows ?) > I'm pretty sure the answer is no, after searching a bit for mingw and

Re: [RFC 0/3] imap-send curl tunnelling support

(Sent a reply from my phone while out of town but couldn't find it so here it is again) It's available on my github: https://github.com/nmorey/git/tree/dev/curl-tunnel The series had been stlighly changed since the patch were posted, mostly to add the proper ifdefs to handle older curl

Re: [RFC 0/3] imap-send curl tunnelling support

Hi, On Tue, 15 Aug 2017, Stefan Beller wrote: > On Tue, Aug 15, 2017 at 10:49 AM, Nicolas Morey-Chaisemartin > wrote: > > Ping. > > > > I'd like to get feedback from Windows developer on patch #2 > > Patch#3 will probably need some updates as I expected Jeff old

Re: [RFC 0/3] imap-send curl tunnelling support

On Tue, Aug 15, 2017 at 07:46:11PM +0200, Nicolas Morey-Chaisemartin wrote: > Patch#3 will probably need some updates as I expected Jeff old curl drop > patches to make it in. > As it seems to be going another way a few more ifdefs will be required I'm not sure where we're going with the

Re: [RFC 0/3] imap-send curl tunnelling support

On Wed, Aug 09, 2017 at 04:43:26PM +0200, Nicolas Morey-Chaisemartin wrote: > I have a few doubt on patch #2: > - is socketpair working on all git supported system (windows ?) I'm pretty sure the answer is no, after searching a bit for mingw and socketpair. The big question is whether we could

Re: [RFC 0/3] imap-send curl tunnelling support

On Tue, Aug 15, 2017 at 10:49 AM, Nicolas Morey-Chaisemartin wrote: > Ping. > > I'd like to get feedback from Windows developer on patch #2 > Patch#3 will probably need some updates as I expected Jeff old curl drop > patches to make it in. > As it seems to be

Re: [RFC 0/3] imap-send curl tunnelling support

Ping. I'd like to get feedback from Windows developer on patch #2 Patch#3 will probably need some updates as I expected Jeff old curl drop patches to make it in. As it seems to be going another way a few more ifdefs will be required Nicolas Le 09/08/2017 à 16:43, Nicolas Morey-Chaisemartin a

[RFC 0/3] imap-send curl tunnelling support

>From 7.21.5, curl can be tricked into using an open fd. This series uses this to allow using curl over a tunnel. I have a few doubt on patch #2: - is socketpair working on all git supported system (windows ?) - should socketpair always be used or limited to the curl over tunnel case ? I don't