Re: [RFC PATCH 0/5] recursively grep across submodules

2016-10-28 Thread Junio C Hamano
Brandon Williams writes: >> Just a few brief comments, before reading the patches carefully. >> >> * It is somewhat surprising that [1/5] is even needed (in other >>words, I would have expected something like this to be already >>there, and my knee-jerk reaction was

Re: [RFC PATCH 0/5] recursively grep across submodules

2016-10-28 Thread Brandon Williams
On 10/27, Junio C Hamano wrote: > Brandon Williams writes: > > > As for the rest of the series, it should be ready for review or comments. > > Just a few brief comments, before reading the patches carefully. > > * It is somewhat surprising that [1/5] is even needed (in

Re: [RFC PATCH 0/5] recursively grep across submodules

2016-10-28 Thread Philip Oakley
From: "Junio C Hamano" I hate it when people become overly defensive and start making excuses when given harmless observations. Hi Junio, It can sometimes be difficult for readers to appreciate which way comments are meant to be interpreted, especially as one cannot

Re: [RFC PATCH 0/5] recursively grep across submodules

2016-10-27 Thread Stefan Beller
On Thu, Oct 27, 2016 at 7:50 PM, Junio C Hamano wrote: > > Unless you are imagining "git grep" to initialize and checkout a > submodule that is not checked out on-demand, I do not think you have > any reason to even look at ".gitmodules" for the purpose of "I want > to grep

Re: [RFC PATCH 0/5] recursively grep across submodules

2016-10-27 Thread Junio C Hamano
Stefan Beller writes: >> Just a few brief comments, before reading the patches carefully. >> >> * It is somewhat surprising that [1/5] is even needed (in other >>words, I would have expected something like this to be already >>there, and my knee-jerk reaction was

Re: [RFC PATCH 0/5] recursively grep across submodules

2016-10-27 Thread Stefan Beller
On Thu, Oct 27, 2016 at 4:26 PM, Junio C Hamano wrote: > Brandon Williams writes: > >> As for the rest of the series, it should be ready for review or comments. > > Just a few brief comments, before reading the patches carefully. > > * It is somewhat

Re: [RFC PATCH 0/5] recursively grep across submodules

2016-10-27 Thread Junio C Hamano
Brandon Williams writes: > As for the rest of the series, it should be ready for review or comments. Just a few brief comments, before reading the patches carefully. * It is somewhat surprising that [1/5] is even needed (in other words, I would have expected something

[RFC PATCH 0/5] recursively grep across submodules

2016-10-27 Thread Brandon Williams
This patch series adds some basic api functions to the submodule interface as well as teaching grep to recursively search in submodules. The additions to the submodule interface allow grep to verify that a submodule has been initialized and checked out prior to launching a child process. One