Re: [RFC PATCH 2/6] refs/refs-internal.h: avoid forward declaration of an enum

On Mon, Jul 09, 2018 at 09:30:12PM +0200, Beat Bolli wrote: > > Other than this minor quibble, the whole series looks good to me, modulo > > the existing review. > > Ooosp, I've just sent the non-RFC reroll without this change. > > Junio, would you squash this into [1/6] and [2/6], please (if

Re: [RFC PATCH 2/6] refs/refs-internal.h: avoid forward declaration of an enum

On 09.07.18 20:46, Jeff King wrote: > On Sun, Jul 08, 2018 at 04:43:38PM +0200, Beat Bolli wrote: > >> diff --git a/refs/refs-internal.h b/refs/refs-internal.h >> index dd834314bd..a78b5cb803 100644 >> --- a/refs/refs-internal.h >> +++ b/refs/refs-internal.h >> @@ -1,6 +1,8 @@ >> #ifndef

Re: [RFC PATCH 2/6] refs/refs-internal.h: avoid forward declaration of an enum

On Sun, Jul 08, 2018 at 04:43:38PM +0200, Beat Bolli wrote: > diff --git a/refs/refs-internal.h b/refs/refs-internal.h > index dd834314bd..a78b5cb803 100644 > --- a/refs/refs-internal.h > +++ b/refs/refs-internal.h > @@ -1,6 +1,8 @@ > #ifndef REFS_REFS_INTERNAL_H > #define REFS_REFS_INTERNAL_H

[RFC PATCH 2/6] refs/refs-internal.h: avoid forward declaration of an enum

Include iterator.h to define enum iterator_selection. Signed-off-by: Beat Bolli --- refs/refs-internal.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/refs/refs-internal.h b/refs/refs-internal.h index dd834314bd..a78b5cb803 100644 --- a/refs/refs-internal.h +++ b/refs/refs-internal.h @@