Re: [RFC PATCH v2 06/12] submodule--helper: add a '--stage' option to the 'config' sub command

2018-08-07 Thread Antonio Ospite
On Mon, 06 Aug 2018 10:38:20 -0700 Junio C Hamano wrote: > Antonio Ospite writes: > > >> I also do not see a reason why we want to stop referring to > >> .gitmodules explicitly by name. We do not hide the fact that > >> in-tree .gitignore and .gitattributes files are used to hold the > >>

Re: [RFC PATCH v2 06/12] submodule--helper: add a '--stage' option to the 'config' sub command

2018-08-06 Thread Stefan Beller
> The consistency I was referring to is merely in the mechanism used to > deal with .gitmodules: by always using "submodule--helper config". > > As a side argument: in some previous discussion Stefan mentioned the > possibility that, in the future, he may be interested to explore > different

Re: [RFC PATCH v2 06/12] submodule--helper: add a '--stage' option to the 'config' sub command

2018-08-06 Thread Junio C Hamano
Antonio Ospite writes: >> I also do not see a reason why we want to stop referring to >> .gitmodules explicitly by name. We do not hide the fact that >> in-tree .gitignore and .gitattributes files are used to hold the >> metainformation about the project tree, saying that it is an >>

Re: [RFC PATCH v2 06/12] submodule--helper: add a '--stage' option to the 'config' sub command

2018-08-06 Thread Antonio Ospite
On Fri, 03 Aug 2018 09:24:14 -0700 Junio C Hamano wrote: > Antonio Ospite writes: > > > The rationale behind the change is to close the circle started with 04 > > and 05 and stop referring to .gitmodules explicitly by file path in git > > commands. The change is not strictly needed for the

Re: [RFC PATCH v2 06/12] submodule--helper: add a '--stage' option to the 'config' sub command

2018-08-03 Thread Junio C Hamano
Antonio Ospite writes: > The rationale behind the change is to close the circle started with 04 > and 05 and stop referring to .gitmodules explicitly by file path in git > commands. The change is not strictly needed for the series, it's for > consistency sake. Sorry, but I am still not quite

Re: [RFC PATCH v2 06/12] submodule--helper: add a '--stage' option to the 'config' sub command

2018-08-03 Thread Antonio Ospite
On Thu, 02 Aug 2018 11:57:14 -0700 Junio C Hamano wrote: > Antonio Ospite writes: > > > Add a --stage option to the 'submodule--helper config' command so that > > the .gitmodules file can be staged without referring to it explicitly by > > its file path. > > Sorry, but I have no clue what the

Re: [RFC PATCH v2 06/12] submodule--helper: add a '--stage' option to the 'config' sub command

2018-08-02 Thread Junio C Hamano
Antonio Ospite writes: > Add a --stage option to the 'submodule--helper config' command so that > the .gitmodules file can be staged without referring to it explicitly by > its file path. Sorry, but I have no clue what the above is trying to say. The original 's--h config []' is quite

[RFC PATCH v2 06/12] submodule--helper: add a '--stage' option to the 'config' sub command

2018-08-02 Thread Antonio Ospite
Add a --stage option to the 'submodule--helper config' command so that the .gitmodules file can be staged without referring to it explicitly by its file path. In practice the config will still be written to .gitmodules, there are no plans to change the file path, but having this level of