Re: [PATCH] sub-process: refactor handshake to common function

2017-07-26 Thread Junio C Hamano
Lars Schneider writes: > Please note that I've recently refactored the capabilities negotiation a bit: > https://github.com/git/git/commit/1514c8edd62d96006cd1de31e906ed5798dd4681 > > This change is still cooking in `next`. I am not sure how this should/could > be

Re: [PATCH] sub-process: refactor handshake to common function

2017-07-26 Thread Lars Schneider
> On 24 Jul 2017, at 23:38, Jonathan Tan wrote: > > Refactor, into a common function, the version and capability negotiation > done when invoking a long-running process as a clean or smudge filter. > This will be useful for other Git code that needs to interact

Re: [PATCH] sub-process: refactor handshake to common function

2017-07-25 Thread Jonathan Tan
On Tue, 25 Jul 2017 10:38:51 -0400 Ben Peart wrote: > Christian Couder has been working on a similar refactoring for the perl > versions of very similar helper functions. They can be found in the > following patch series: > >

Re: [PATCH] sub-process: refactor handshake to common function

2017-07-25 Thread Ben Peart
On 7/24/2017 5:38 PM, Jonathan Tan wrote: Refactor, into a common function, the version and capability negotiation done when invoking a long-running process as a clean or smudge filter. This will be useful for other Git code that needs to interact similarly with a long-running process.

Re: [PATCH] sub-process: refactor handshake to common function

2017-07-24 Thread Jonathan Nieder
Hi, Jonathan Tan wrote: > Refactor, into a common function, the version and capability negotiation > done when invoking a long-running process as a clean or smudge filter. > This will be useful for other Git code that needs to interact similarly > with a long-running process. > > Signed-off-by: