Re: [PATCH 02/15] submodule: don't use submodule_from_name

Hi, sorry for the late reply, just stumpled upon this. On Mon, Jul 31, 2017 at 01:43:04PM -0700, Stefan Beller wrote: > On Sun, Jul 30, 2017 at 6:43 AM, Jens Lehmann wrote: > > Am 26.07.2017 um 23:06 schrieb Junio C Hamano: > >> > >> Stefan Beller

Re: [PATCH 02/15] submodule: don't use submodule_from_name

On Sun, Jul 30, 2017 at 6:43 AM, Jens Lehmann wrote: > Am 26.07.2017 um 23:06 schrieb Junio C Hamano: >> >> Stefan Beller writes: >> >>> Rereading the archives, there was quite some discussion on the design >>> of these patches, but these lines of code

Re: [PATCH 02/15] submodule: don't use submodule_from_name

Jens Lehmann writes: >> I wonder if we should barf loudly if there shouldn't be a submodule >> at that path, i.e. >> >> if (!submodule) >> die("there is no submodule defined for path '%s'"...); >> >> though. > > Not sure if you want to die() or just issue a

Re: [PATCH 02/15] submodule: don't use submodule_from_name

Am 26.07.2017 um 23:06 schrieb Junio C Hamano: Stefan Beller writes: Rereading the archives, there was quite some discussion on the design of these patches, but these lines of code did not get any attention https://public-inbox.org/git/4cdb3063.5010...@web.de/ I

Re: [PATCH 02/15] submodule: don't use submodule_from_name

Stefan Beller writes: > Rereading the archives, there was quite some discussion on the design > of these patches, but these lines of code did not get any attention > > https://public-inbox.org/git/4cdb3063.5010...@web.de/ > > I cc'd Jens in the hope of him having a good

Re: [PATCH 02/15] submodule: don't use submodule_from_name

On Tue, Jul 25, 2017 at 2:39 PM, Brandon Williams wrote: > The function 'submodule_from_name()' is being used incorrectly here as a > submodule path is being used instead of a submodule name. Since the > correct function to use with a path to a submodule is already being used