Re: [PATCH 5/5] streaming: simplify attaching a filter

2014-02-18 Thread Junio C Hamano
John Keeping j...@keeping.me.uk writes: We are guaranteed that 'nst' is non-null because it is allocated with xmalloc(), and in fact we rely on this three lines later by unconditionally dereferencing it. The intent of the original code is for attach_stream_filter() to detect an error

Re: [PATCH 5/5] streaming: simplify attaching a filter

2014-02-18 Thread Junio C Hamano
Junio C Hamano gits...@pobox.com writes: John Keeping j...@keeping.me.uk writes: We are guaranteed that 'nst' is non-null because it is allocated with xmalloc(), and in fact we rely on this three lines later by unconditionally dereferencing it. The intent of the original code is for