Re: Re: Re: Re: Re: Segmentation fault with latest git (070c57df)

2013-02-03 Thread Jongman Heo
Jonathan Nieder wrote: Jongman Heo wrote: But it doesn't stimulate any prerequisites in make, which is weird. What's in builtin/.depend/fetch.o.d? [...] please see below~. $ cat builtin/.depend/fetch.o.d fetch.o: builtin/fetch.c cache.h git-compat-util.h compat/bswap.h \

Re: Re: Segmentation fault with latest git (070c57df)

2013-02-03 Thread Jongman Heo
Jonathan Nieder wrote: Jongman Heo wrote: Unfortunately, the patch didn't help to me. Thanks for testing. Did you apply the patch to the older version of git that generates builtin/.depend/fetch.o.d or the newer version that consumes it? Curious, Jonathan Hi, Jonathan, I applied the

Re: Re: Segmentation fault with latest git (070c57df)

2013-02-01 Thread Jongman Heo
Junio C Hamanogits...@pobox.com wrote : 허종만 writes: But usually when I build upstream Linux kernel, I don't do make clean after git pull.. I didn't expect that I needed make clean for git build. We don't expect anybody need make clean, either. There is something wrong in the dependency.

Re: Re: Segmentation fault with latest git (070c57df)

2013-02-01 Thread Jeff King
On Fri, Feb 01, 2013 at 09:14:41AM +, Jongman Heo wrote: I can reproduce the issue in my machine (RedHat Enterprise 5, x86 PAE) as follows. Great, thanks for taking the time to reproduce. But in my different machine (Fedora 16 x86) I can't reproduce. That makes me wonder if it is

Re: Re: Re: Segmentation fault with latest git (070c57df)

2013-02-01 Thread Jeff King
On Fri, Feb 01, 2013 at 10:30:24AM +, Jongman Heo wrote: Short answer; * Version of make is 3.81 on both machines * builtin/fetch.o is not rebuilt (see entire log below) * git works fine with make all install COMPUTE_HEADER_DEPENDENCIES=no OK, that gets us closer. It's definitely a

Re: Re: Re: Re: Segmentation fault with latest git (070c57df)

2013-02-01 Thread Jongman Heo
[...] Finished prerequisites of target file `builtin/fetch.o'. Prerequisite `builtin/fetch.c' is older than target `builtin/fetch.o'. Prerequisite `GIT-CFLAGS' is older than target `builtin/fetch.o'. No need to remake target `builtin/fetch.o'. But it doesn't stimulate any prerequisites

Re: Re: Re: Re: Segmentation fault with latest git (070c57df)

2013-02-01 Thread Jonathan Nieder
Jongman Heo wrote: But it doesn't stimulate any prerequisites in make, which is weird. What's in builtin/.depend/fetch.o.d? [...] please see below~. $ cat builtin/.depend/fetch.o.d fetch.o: builtin/fetch.c cache.h git-compat-util.h compat/bswap.h \ That's the problem. See the

Re: Re: Re: Segmentation fault with latest git (070c57df)

2013-01-31 Thread 허종만
It's almost like the compiler is getting the initializer wrong. It's a long shot, but I wonder if the presence of the bitfield could be triggering a compiler bug (or there is a subtle C rule about bitfield initializations that I do not know). Just for the sake of my sanity, what does the

Re: Re: Segmentation fault with latest git (070c57df)

2013-01-31 Thread 허종만
[snip] Good point. Unfortunately, I can't get either yours or mine to fail, neither with a recent version of gcc nor with gcc-4.1. But I can't convince git to fail, either. The only gcc-4.1 I have is Debian's 4.1.3 release, which is not quite what the OP has. Or perhaps something in

Re: Re: Segmentation fault with latest git (070c57df)

2013-01-30 Thread Jongman Heo
On Thu, Jan 31, 2013 at 7:49 AM, Jeff King wrote: On Thu, Jan 31, 2013 at 01:35:21AM +, Jongman Heo wrote: Looks like following commit causes a segmentation fault in my machine (when running git pull or git fetch); commit 8dd5afc926acb9829ebf56e9b78826a5242cd638 Author: Junio C Hamano

Re: Re: Segmentation fault with latest git (070c57df)

2013-01-30 Thread Jeff King
On Thu, Jan 31, 2013 at 07:27:04AM +, Jongman Heo wrote: FYI, gdb backtrace and valgrind output attached below, Thanks. Thanks, that's helpful. #4 0x0812bda0 in string_list_insert (list=0xbfffe7c0, string=0x821ec3c refs/remotes/origin/HEAD) at string-list.c:57 #5 0x08071838 in