[PATCH 0/2] Re: git diff --submodule=diff fails with submodules in a submodule

2017-03-31 Thread Stefan Beller
I came up with a patch that fixes the issue locally. (It is the first patch, such that we can track the first patch down to maint) While doing so, I noticed 2 issues: * when having nested submodules, we probably want to have --submodule=diff to recurse into the nested submodules, so pass on the

Re: git diff --submodule=diff fails with submodules in a submodule

2017-03-31 Thread Jacob Keller
On Fri, Mar 31, 2017 at 10:07 AM, Stefan Beller wrote: > +cc Jacob, who implemented --submodule=diff > > On Fri, Mar 31, 2017 at 8:40 AM, David Parrish wrote: >> When I try to run `git diff --submodule=diff` in a submodule which has >> it's own

Re: git diff --submodule=diff fails with submodules in a submodule

2017-03-31 Thread Stefan Beller
+cc Jacob, who implemented --submodule=diff On Fri, Mar 31, 2017 at 8:40 AM, David Parrish wrote: > When I try to run `git diff --submodule=diff` in a submodule which has > it's own submodules that have changes I get the error: fatal: bad > object Thanks for the bug

git diff --submodule=diff fails with submodules in a submodule

2017-03-31 Thread David Parrish
When I try to run `git diff --submodule=diff` in a submodule which has it's own submodules that have changes I get the error: fatal: bad object Let me know if you need an example reproduce the issue. David