Re: [PATCH v2 0/7] thread lazy_init_name_hash

2017-04-05 Thread Duy Nguyen
On Thu, Mar 23, 2017 at 8:46 PM, wrote: > This patch series is a performance optimization for > lazy_init_name_hash() in name-hash.c on very large > repositories. > > This change allows lazy_init_name_hash() to optionally > use multiple threads when building the

[PATCH v8 2/5] remove_subtree(): test removing nested directories

2017-04-05 Thread Daniel Ferreira
Test removing a nested directory when an attempt is made to restore the index to a state where it does not exist. A similar test could be found previously in t/t2000-checkout-cache-clash.sh, but it did not check for nested directories, which could allow a faulty implementation of remove_subtree()

[PATCH v8 4/5] dir_iterator: refactor state machine model

2017-04-05 Thread Daniel Ferreira
Perform major refactor of dir_iterator_advance(). dir_iterator has ceased to rely on a convoluted state machine mechanism of two loops and two state variables (level.initialized and level.dir_state). This serves to ease comprehension of the iterator mechanism and ease addition of new features to

[PATCH v8 3/5] dir_iterator: add helpers to dir_iterator_advance

2017-04-05 Thread Daniel Ferreira
Create helpers to dir_iterator_advance(). Make dir_iterator_advance()'s code more legible and allow some behavior to be reusable. Signed-off-by: Daniel Ferreira --- dir-iterator.c | 65 +- 1 file changed, 42

[PATCH v8 5/5] remove_subtree(): reimplement using iterators

2017-04-05 Thread Daniel Ferreira
Use dir_iterator to traverse through remove_subtree()'s directory tree, avoiding the need for recursive calls to readdir(). Simplify remove_subtree()'s code. A conversion similar in purpose was previously done at 46d092a ("for_each_reflog(): reimplement using iterators", 2016-05-21).

[PATCH v8 1/5] dir_iterator: add tests for dir_iterator API

2017-04-05 Thread Daniel Ferreira
Create t/helper/test-dir-iterator.c, which prints relevant information about a directory tree iterated over with dir_iterator. Create t/t0065-dir-iterator.sh, which tests that dir_iterator does iterate through a whole directory tree. Signed-off-by: Daniel Ferreira ---

[PATCH v8 0/5] [GSoC] remove_subtree(): reimplement using iterators

2017-04-05 Thread Daniel Ferreira
This is the seventh version of a patch series that implements the GSoC microproject of converting a recursive call to readdir() to use dir_iterator. v1: https://public-inbox.org/git/CAGZ79kZwT-9mHTiOJ5CEjk2wDFkn6+NcogjX0=vjhsah16a...@mail.gmail.com/T/#t v2:

Re: [RFC] dropping support for ancient versions of curl

2017-04-05 Thread Todd Zullinger
brian m. carlson wrote: On Wed, Apr 05, 2017 at 12:51:38PM +0200, Ævar Arnfjörð Bjarmason wrote: On Wed, Apr 5, 2017 at 11:33 AM, Tom G. Christensen wrote: Whoah. So my assumption in that nobody was

Re: [RFC] dropping support for ancient versions of curl

2017-04-05 Thread brian m. carlson
On Wed, Apr 05, 2017 at 12:51:38PM +0200, Ævar Arnfjörð Bjarmason wrote: > On Wed, Apr 5, 2017 at 11:33 AM, Tom G. Christensen > wrote: > Whoah. So my assumption in > > that nobody was compiling this &

Re: [PATCH v2 2/2] push: propagate push-options with --recurse-submodules

2017-04-05 Thread Jacob Keller
On Fri, Mar 31, 2017 at 5:19 PM, Jonathan Nieder wrote: > Brandon Williams wrote: > >> Teach push --recurse-submodules to propagate push-options recursively to >> the pushes performed in the submodules. > > Some time in the future we may want "push --recurse-submodules" to do

Why does git-checkout accept a tree-ish?

2017-04-05 Thread Dan Fabulich
I was looking back through git's history, trying to figure out why git-checkout has so many features. I was struck by this commit by Junio in 2005. https://github.com/git/git/commit/4aaa702794447d9b281dd22fe532fd61e02434e1 > git-checkout: revert specific paths to either index or a given

Re: [PATCH v5 4/4] read-cache: speed up add_index_entry during checkout

2017-04-05 Thread SZEDER Gábor
> Teach add_index_entry_with_check() and has_dir_name() > to see if the path of the new item is greater than the > last path in the index array before attempting to search > for it. > > During checkout, merge_working_tree() populates the new > index in sorted order, so this change saves at least

Re: [PATCH v5 3/4] test-strcmp-offset: created test for strcmp_offset

2017-04-05 Thread SZEDER Gábor
I think this patch should be squashed into the previous commit; I don't see any reason why the tests should be added in a different commit than the function they are testing. However... > Signed-off-by: Jeff Hostetler > --- > Makefile | 1 + >

Re: [PATCH v2 1/2] string-list: use ALLOC_GROW macro when reallocing string_list

2017-04-05 Thread Jonathan Nieder
g...@jeffhostetler.com wrote: > During status on a very large repo and there are many changes, > a significant percentage of the total run time was spent nit: s/was/is/ (see comments on v1) > reallocing the wt_status.changes array. [...] > Signed-off-by: Jeff Hostetler

Re: [PATCH v1 2/2] p0005-status: time status on very large repo

2017-04-05 Thread Jonathan Nieder
Hi, g...@jeffhostetler.com wrote: > +++ b/t/perf/p0005-status.sh > @@ -0,0 +1,70 @@ > +#!/bin/sh > + > +test_description="Tests performance of read-tree" > + > +. ./perf-lib.sh > + > +test_perf_default_repo > +test_checkout_worktree > + > +## usage: dir depth width files > +make_paths () { > +

Re: [PATCH v1 1/2] string-list: use ALLOC_GROW macro when reallocing string_list

2017-04-05 Thread Jonathan Nieder
Hi, g...@jeffhostetler.com wrote: > During status on a very large repo and there are many changes, > a significant percentage of the total run time was spent > reallocing the wt_status.changes array. Nit: commit messages tend to use the present tense instead of the past when describing Git's

Re: [PATCH v1 1/2] string-list: use ALLOC_GROW macro when reallocing string_list

2017-04-05 Thread Jeff Hostetler
On 4/5/2017 4:09 PM, Jeff King wrote: On Wed, Apr 05, 2017 at 07:55:59PM +, g...@jeffhostetler.com wrote: From: Jeff Hostetler Use ALLOC_GROW() macro when reallocing a string_list array rather than simply increasing it by 32. This is a performance optimization.

[PATCH v2 1/2] string-list: use ALLOC_GROW macro when reallocing string_list

2017-04-05 Thread git
From: Jeff Hostetler Use ALLOC_GROW() macro when reallocing a string_list array rather than simply increasing it by 32. This is a performance optimization. During status on a very large repo and there are many changes, a significant percentage of the total run time was

[PATCH v2 0/2] string-list: use ALLOC_GROW macro when reallocing

2017-04-05 Thread git
From: Jeff Hostetler Use ALLOC_GROW() macro when reallocating a string_list array rather than simply increasing it by 32. This helps performance of status on very large repos on Windows. Jeff Hostetler (2): string-list: use ALLOC_GROW macro when reallocing string_list

[PATCH v2 2/2] p0005-status: time status on very large repo

2017-04-05 Thread git
From: Jeff Hostetler Signed-off-by: Jeff Hostetler --- t/perf/p0005-status.sh | 70 ++ 1 file changed, 70 insertions(+) create mode 100644 t/perf/p0005-status.sh diff --git

Re: [PATCH v1 1/2] string-list: use ALLOC_GROW macro when reallocing string_list

2017-04-05 Thread Jeff King
On Wed, Apr 05, 2017 at 07:55:59PM +, g...@jeffhostetler.com wrote: > From: Jeff Hostetler > > Use ALLOC_GROW() macro when reallocing a string_list array > rather than simply increasing it by 32. This is a performance > optimization. > > During status on a very

Re: [PATCH v1 1/2] string-list: use ALLOC_GROW macro when reallocing string_list

2017-04-05 Thread Stefan Beller
On Wed, Apr 5, 2017 at 12:55 PM, wrote: > + if (list->nr + 1 >= list->alloc) > + ALLOC_GROW(list->items, list->nr+1, list->alloc); No need for the condition here as it is part of the macro as well. Thanks for spotting this fix! Stefan

[PATCH v1 1/2] string-list: use ALLOC_GROW macro when reallocing string_list

2017-04-05 Thread git
From: Jeff Hostetler Use ALLOC_GROW() macro when reallocing a string_list array rather than simply increasing it by 32. This is a performance optimization. During status on a very large repo and there are many changes, a significant percentage of the total run time was

[PATCH v1 2/2] p0005-status: time status on very large repo

2017-04-05 Thread git
From: Jeff Hostetler Signed-off-by: Jeff Hostetler --- t/perf/p0005-status.sh | 70 ++ 1 file changed, 70 insertions(+) create mode 100644 t/perf/p0005-status.sh diff --git

[PATCH v1 0/2] string-list: use ALLOC_GROW macro when reallocing

2017-04-05 Thread git
From: Jeff Hostetler Use ALLOC_GROW() macro when reallocating a string_list array rather than simply increasing it by 32. This helps performance of status on very large repos on Windows. Jeff Hostetler (2): string-list: use ALLOC_GROW macro when reallocing string_list

Re: [PATCH v6] read-cache: force_verify_index_checksum

2017-04-05 Thread Jeff Hostetler
On 4/5/2017 2:25 PM, Jeff King wrote: On Wed, Apr 05, 2017 at 06:06:25PM +, g...@jeffhostetler.com wrote: --- builtin/fsck.c | 1 + cache.h | 2 ++ read-cache.c| 7 +++ t/t1450-fsck.sh | 13 + 4 files changed, 23 insertions(+) This version is

Re: [PATCH v6] read-cache: force_verify_index_checksum

2017-04-05 Thread Jonathan Nieder
Hi, g...@jeffhostetler.com wrote: > --- a/t/t1450-fsck.sh > +++ b/t/t1450-fsck.sh > @@ -689,4 +689,17 @@ test_expect_success 'bogus head does not fallback to all > heads' ' > ! grep $blob out > ' > > +test_expect_success 'detect corrupt index file in fsck' ' > + cp .git/index

Re: [PATCH v6] read-cache: force_verify_index_checksum

2017-04-05 Thread Jeff King
On Wed, Apr 05, 2017 at 06:06:25PM +, g...@jeffhostetler.com wrote: > --- > builtin/fsck.c | 1 + > cache.h | 2 ++ > read-cache.c| 7 +++ > t/t1450-fsck.sh | 13 + > 4 files changed, 23 insertions(+) This version is delightfully simple. Thanks for sticking

Re: [PATCH v5] read-cache: force_verify_index_checksum

2017-04-05 Thread Jeff Hostetler
On 4/5/2017 1:03 PM, Jonathan Nieder wrote: Hi, g...@jeffhostetler.com wrote: Signed-off-by: Jeff Hostetler --- builtin/fsck.c | 1 + cache.h | 2 ++ read-cache.c| 7 +++ t/t1450-fsck.sh | 11 +++ 4 files changed, 21 insertions(+) Yay!

[PATCH v6] read-cache: force_verify_index_checksum

2017-04-05 Thread git
From: Jeff Hostetler Teach git to skip verification of the SHA1-1 checksum at the end of the index file in verify_hdr() which is called from read_index() unless the "force_verify_index_checksum" global variable is set. Teach fsck to force this verification. The checksum

[PATCH v6] read-cache: call verify_hdr() in a background thread

2017-04-05 Thread git
From: Jeff Hostetler Version 6 of this patch series cleans up a little further and uses test_when_finished in the unit test. Version 5 of this patch series further simplifies the change to a single global variable for use by fsck. It eliminates the core

[PATCH v3 3/5] remote: expose parse_push_refspec function

2017-04-05 Thread Brandon Williams
A future patch needs access to the 'parse_push_refspec()' function so let's export the function so other modules can use it. Signed-off-by: Brandon Williams --- remote.c | 2 +- remote.h | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/remote.c b/remote.c

[PATCH v3 2/5] push: propagate push-options with --recurse-submodules

2017-04-05 Thread Brandon Williams
Teach push --recurse-submodules to propagate push-options recursively to the pushes performed in the submodules. Signed-off-by: Brandon Williams --- submodule.c | 13 +++-- submodule.h | 1 + t/t5545-push-options.sh | 40

[PATCH v3 1/5] push: unmark a local variable as static

2017-04-05 Thread Brandon Williams
There isn't any obvious reason for the 'struct string_list push_options' and 'struct string_list_item *item' to be marked as static, so unmark them as being static. Also, clear the push_options string_list to prevent memory leaking. Signed-off-by: Brandon Williams ---

[PATCH v3 4/5] submodule--helper: add push-check subcommand

2017-04-05 Thread Brandon Williams
Add the 'push-check' subcommand to submodule--helper which is used to check if the provided remote and refspec can be used as part of a push operation in the submodule. Signed-off-by: Brandon Williams --- builtin/submodule--helper.c | 45

[PATCH v3 5/5] push: propagate remote and refspec with --recurse-submodules

2017-04-05 Thread Brandon Williams
Teach "push --recurse-submodules" to propagate, if given a name as remote, the provided remote and refspec recursively to the pushes performed in the submodules. The push will therefore only succeed if all submodules have a remote with such a name configured. Note that "push --recurse-submodules"

[PATCH v3 0/5] propagating push-options, remote and refspec

2017-04-05 Thread Brandon Williams
v3 builds upon v2 by adding 3 additional patches to add functionality to also propagate the remote and refspec down to children process's working to push submodules. The remote and refspec will only be propagated if the provided remote is configured. A remote provided in the form of a URL will

[PATCH v5 2/4] read-cache: add strcmp_offset function

2017-04-05 Thread git
From: Jeff Hostetler Add strcmp_offset() function to also return the offset of the first change. Signed-off-by: Jeff Hostetler --- cache.h | 1 + read-cache.c | 29 + 2 files changed, 30 insertions(+) diff

[PATCH v5 4/4] read-cache: speed up add_index_entry during checkout

2017-04-05 Thread git
From: Jeff Hostetler Teach add_index_entry_with_check() and has_dir_name() to see if the path of the new item is greater than the last path in the index array before attempting to search for it. During checkout, merge_working_tree() populates the new index in sorted

[PATCH v5 1/4] p0004-read-tree: perf test to time read-tree

2017-04-05 Thread git
From: Jeff Hostetler Signed-off-by: Jeff Hostetler --- t/perf/p0004-read-tree.sh | 116 ++ 1 file changed, 116 insertions(+) create mode 100755 t/perf/p0004-read-tree.sh diff --git

[PATCH v5 3/4] test-strcmp-offset: created test for strcmp_offset

2017-04-05 Thread git
From: Jeff Hostetler Signed-off-by: Jeff Hostetler --- Makefile | 1 + t/helper/.gitignore | 1 + t/helper/test-strcmp-offset.c | 64 +++ t/t0065-strcmp-offset.sh | 11

[PATCH v5 0/4] read-cache: speed up add_index_entry

2017-04-05 Thread git
From: Jeff Hostetler [This is labeled as version 5 because of a cut-n-paste accident where my first version of this patch was labeled version 4.] This version adds more perf tests to p0004-read-tree.sh Teach add_index_entry_with_check() and

Re: [PATCH v5] read-cache: force_verify_index_checksum

2017-04-05 Thread Jonathan Nieder
Hi, g...@jeffhostetler.com wrote: > Signed-off-by: Jeff Hostetler > --- > builtin/fsck.c | 1 + > cache.h | 2 ++ > read-cache.c| 7 +++ > t/t1450-fsck.sh | 11 +++ > 4 files changed, 21 insertions(+) Yay! I love this version. > ---

[ANNOUNCE] Git for Windows 2.12.2(2)

2017-04-05 Thread Johannes Schindelin
Dear Git users, It is my pleasure to announce that Git for Windows 2.12.2(2) is available from: https://git-for-windows.github.io/ Changes since Git for Windows v2.12.2 (March 27th 2017) New Features * Portable Git is now using a custom-built SFX that is based directly on

Re: [PATCH 4/7] Handle missing HTTP_CONNECTCODE in curl < 7.10.7

2017-04-05 Thread Franke, Knut
On 2017-04-05 15:50, Ævar Arnfjörð Bjarmason wrote: > This effectively disables that code & this later check: > > + if (results->http_connectcode == 407) > + credential_reject(_auth); > > What's the impact of not taking that branch when the proxy returns a

[PATCH v5] read-cache: call verify_hdr() in a background thread

2017-04-05 Thread git
From: Jeff Hostetler Version 5 of this patch series further simplifies the change to a single global variable for use by fsck. It eliminates the core config setting. Further discussion on the mailing list indicated that the config setting only added confusion and

[PATCH v5] read-cache: force_verify_index_checksum

2017-04-05 Thread git
From: Jeff Hostetler Teach git to skip verification of the SHA1-1 checksum at the end of the index file in verify_hdr() which is called from read_index() unless the "force_verify_index_checksum" global variable is set. Teach fsck to force this verification. The checksum

Re: [PATCH 3/7] Allow svnrdump_sim.py to be used with Python 2.2

2017-04-05 Thread Tom G. Christensen
On 05/04/17 15:40, Ævar Arnfjörð Bjarmason wrote: On Wed, Apr 5, 2017 at 3:04 PM, Tom G. Christensen wrote: This allows running the git-svn testsuite with Python 2.2. +CC-ing Eric S. Raymond who added these version limitations in a33faf2827. Also, in his patch

Re: [PATCH v2 00/20] Separate `ref_cache` into a separate module

2017-04-05 Thread Duy Nguyen
On Sat, Apr 1, 2017 at 12:16 PM, Michael Haggerty wrote: > Duy, have you looked over my patch series? Since you've been working in > the area, your feedback would be very welcome, if you have the time for it. You probably have guessed my answer based on my lack of response

Re: [PATCH 4/7] Handle missing HTTP_CONNECTCODE in curl < 7.10.7

2017-04-05 Thread Ævar Arnfjörð Bjarmason
On Wed, Apr 5, 2017 at 3:04 PM, Tom G. Christensen wrote: > With curl < 7.10.7 we cannot get the proxy CONNECT response code. > As a workaround set it to zero which means no response code available. CC-ing Knut Franke which added this code in

Re: [PATCH 7/7] Do not use curl_easy_strerror with curl < 7.12.0

2017-04-05 Thread Ævar Arnfjörð Bjarmason
On Wed, Apr 5, 2017 at 3:04 PM, Tom G. Christensen wrote: > Commit 17966c0a added an unguarded use of curl_easy_strerror. > This adds a guard so it is not used with curl < 7.12.0. Looks good to me. Eric Wong added this in 17966c0a63. > Signed-off-by: Tom G. Christensen

Re: [PATCH 6/7] Handle missing CURLINFO_SSL_DATA_{IN,OUT}

2017-04-05 Thread Ævar Arnfjörð Bjarmason
On Wed, Apr 5, 2017 at 3:04 PM, Tom G. Christensen wrote: > Do not try and use CURLINFO_SSL_DATA_{IN,OUT} for curl < 7.12.1. Disables code added by Elia Pinto in 74c682d3c6. Looks harmless to me since it's just omitting some information when GIT_TRACE_CURL is set. >

Re: [PATCH v2] pathspec: honor `PATHSPEC_PREFIX_ORIGIN` with empty prefix

2017-04-05 Thread Duy Nguyen
On Tue, Apr 4, 2017 at 11:39 PM, Brandon Williams wrote: >> This is the second version of [1]. It fixes a bug catched by >> Brandon when the pathspec is resolved to the empty string and >> improves the test a bit to actually catch this issue. > > This version looks good to me.

Re: [PATCH 5/7] Add support for gnupg < 1.4

2017-04-05 Thread Ævar Arnfjörð Bjarmason
On Wed, Apr 5, 2017 at 3:04 PM, Tom G. Christensen wrote: > This adds an OLD_GNUPG define to the Makefile which when activated will > ensure git does not use the --keyid-format argument when calling the > 'gpg' program. > This is consistent with how 'gpg' was used in git <

Re: [PATCH 3/7] Allow svnrdump_sim.py to be used with Python 2.2

2017-04-05 Thread Ævar Arnfjörð Bjarmason
On Wed, Apr 5, 2017 at 3:04 PM, Tom G. Christensen wrote: > This allows running the git-svn testsuite with Python 2.2. +CC-ing Eric S. Raymond who added these version limitations in a33faf2827. Also, in his patch contrib/svn-fe/svnrdump_sim.py,

Re: [PATCH] pathspec: always honor `PATHSPEC_PREFIX_ORIGIN` flag

2017-04-05 Thread Duy Nguyen
On Mon, Apr 3, 2017 at 11:26 PM, Brandon Williams wrote: > On 04/03, Patrick Steinhardt wrote: >> Previous to commit 5d8f084a5 (pathspec: simpler logic to prefix original >> pathspec elements, 2017-01-04), we were always using the computed >> `match` variable to perform

Re: [RFC] dropping support for ancient versions of curl

2017-04-05 Thread Tom G. Christensen
On 05/04/17 12:51, Ævar Arnfjörð Bjarmason wrote: On Wed, Apr 5, 2017 at 11:33 AM, Tom G. Christensen wrote: Whoah. So my assumption in that nobody was compiling this & thus not reporting failures was

[PATCH 7/7] Do not use curl_easy_strerror with curl < 7.12.0

2017-04-05 Thread Tom G. Christensen
Commit 17966c0a added an unguarded use of curl_easy_strerror. This adds a guard so it is not used with curl < 7.12.0. Signed-off-by: Tom G. Christensen --- http.c | 4 1 file changed, 4 insertions(+) diff --git a/http.c b/http.c index a46ab23af..104caaa75 100644 ---

[PATCH 6/7] Handle missing CURLINFO_SSL_DATA_{IN,OUT}

2017-04-05 Thread Tom G. Christensen
Do not try and use CURLINFO_SSL_DATA_{IN,OUT} for curl < 7.12.1. Signed-off-by: Tom G. Christensen --- http.c | 4 1 file changed, 4 insertions(+) diff --git a/http.c b/http.c index ce618bdca..a46ab23af 100644 --- a/http.c +++ b/http.c @@ -649,10 +649,12 @@ static

[PATCH 2/7] Install man pages when NO_PERL_MAKEMAKER is used

2017-04-05 Thread Tom G. Christensen
This adds man page installation when using NO_PERL_MAKEMAKER to ensure parity with the normal case where ExtUtils::MakeMaker is used. Signed-off-by: Tom G. Christensen --- perl/Makefile | 13 + 1 file changed, 13 insertions(+) diff --git a/perl/Makefile

[PATCH 0/7] Patches to support older RHEL releases

2017-04-05 Thread Tom G. Christensen
These are patches currently needed to support building and running git on RHEL/CentOS 3 and 4. Tom G. Christensen (7): Make NO_PERL_MAKEMAKER behave more like ExtUtils::MakeMaker Install man pages when NO_PERL_MAKEMAKER is used Allow svnrdump_sim.py to be used with Python 2.2 Handle

[PATCH 5/7] Add support for gnupg < 1.4

2017-04-05 Thread Tom G. Christensen
This adds an OLD_GNUPG define to the Makefile which when activated will ensure git does not use the --keyid-format argument when calling the 'gpg' program. This is consistent with how 'gpg' was used in git < 2.10.0 and slightly decreases security. Signed-off-by: Tom G. Christensen

[PATCH 3/7] Allow svnrdump_sim.py to be used with Python 2.2

2017-04-05 Thread Tom G. Christensen
This allows running the git-svn testsuite with Python 2.2. Signed-off-by: Tom G. Christensen --- contrib/svn-fe/svnrdump_sim.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/contrib/svn-fe/svnrdump_sim.py b/contrib/svn-fe/svnrdump_sim.py index

[PATCH 1/7] Make NO_PERL_MAKEMAKER behave more like ExtUtils::MakeMaker

2017-04-05 Thread Tom G. Christensen
This change makes NO_PERL_MAKEMAKER behave more as ExtUtils::MakeMaker by installing the modules into the perl libdir and not $(prefix)/lib. It will default to sitelib but will allow the user to choose by setting the INSTALLDIRS variable which is also honored by ExtUtils::MakeMaker.

[PATCH 4/7] Handle missing HTTP_CONNECTCODE in curl < 7.10.7

2017-04-05 Thread Tom G. Christensen
With curl < 7.10.7 we cannot get the proxy CONNECT response code. As a workaround set it to zero which means no response code available. Signed-off-by: Tom G. Christensen --- http.c | 4 1 file changed, 4 insertions(+) diff --git a/http.c b/http.c index

Re: [PATCH/RFC] gitperformance: add new documentation about git performance tuning

2017-04-05 Thread Duy Nguyen
On Tue, Apr 4, 2017 at 4:16 AM, Ævar Arnfjörð Bjarmason wrote: > Things I have on my TODO list: Always keep cache-tree valid. I think there's some changes in "git checkout" to rebuild cache-tree often, so it's probably not as bad as before. I don't know if there's a command to

Re: [RFC] dropping support for ancient versions of curl

2017-04-05 Thread Ævar Arnfjörð Bjarmason
On Wed, Apr 5, 2017 at 11:33 AM, Tom G. Christensen wrote: > On 04/04/17 04:54, Jeff King wrote: >> >> A nearby thread raised the question of whether we can rely on a version >> of libcurl that contains a particular feature. The version in question >> is curl 7.11.1, which

[PATCH v2 2/2] config: resolve symlinks in conditional include's patterns

2017-04-05 Thread Nguyễn Thái Ngọc Duy
$GIT_DIR returned by get_git_dir() is normalized, with all symlinks resolved (see setup_work_tree function). In order to match paths (or patterns) against $GIT_DIR char-by-char, they have to be normalized too. There is a note in config.txt about this, that the user need to resolve symlinks by

[PATCH v2 1/2] path.c: and an option to call real_path() in expand_user_path()

2017-04-05 Thread Nguyễn Thái Ngọc Duy
In the next patch we need the ability to expand '~' to real_path($HOME). But we can't do that from outside because '~' is part of a pattern, not a true path. Add an option to expand_user_path() to do so. Signed-off-by: Nguyễn Thái Ngọc Duy --- No changes in v2.

Re: How can I make a best dissertation paper?

2017-04-05 Thread mariam niaz
for best dissertation the writer have complete know how about the topic.because writing is not as simple as we are taking it.it needs a lot of search related to writing essayz topic on which you are going to write.it sets the reader mind. -- View this message

Re: [RFC] dropping support for ancient versions of curl

2017-04-05 Thread Tom G. Christensen
On 04/04/17 04:54, Jeff King wrote: A nearby thread raised the question of whether we can rely on a version of libcurl that contains a particular feature. The version in question is curl 7.11.1, which came out in March 2004. My feeling is that this is old enough to stop caring about. Which

Re: [RFC] dropping support for ancient versions of curl

2017-04-05 Thread Jeff King
On Wed, Apr 05, 2017 at 10:49:47AM +0200, Johannes Schindelin wrote: > Let's reiterate that we are talking about some #ifdef's here that are a > tiny maintenance burden. That may have a bug here and there, easily fixed. Forget the maintenance cost for a moment. My concern is that we are doing

Re: [PATCH v4 2/5] dir_iterator: iterate over dir after its contents

2017-04-05 Thread Duy Nguyen
On Sun, Apr 2, 2017 at 11:25 AM, Daniel Ferreira (theiostream) wrote: > Why exactly would it not be applicable to read_directory_recursively()? Because that function is a beast (and probably should have "beast" in the function name). The function is supposed to read

RE: Segfault on git for Windows

2017-04-05 Thread Rémi Galan Alfonso
> Hi Rémi, > > On Wed, 5 Apr 2017, Rémi Galan Alfonso wrote: > > > At $DAYWORK, the code is versionned under SVN. Since I haven't used SVN > > before and try to have a clean and bisectable history, I installed git > > with the intent to manage my code locally before pushing to SVN when I'm > >

Re: Segfault on git for Windows

2017-04-05 Thread Johannes Schindelin
Hi Rémi, On Wed, 5 Apr 2017, Rémi Galan Alfonso wrote: > At $DAYWORK, the code is versionned under SVN. Since I haven't used SVN > before and try to have a clean and bisectable history, I installed git > with the intent to manage my code locally before pushing to SVN when I'm > satisfied (I

Re: [RFC] dropping support for ancient versions of curl

2017-04-05 Thread Johannes Schindelin
Hi Stefan, On Tue, 4 Apr 2017, Stefan Beller wrote: > On Tue, Apr 4, 2017 at 3:46 PM, Johannes Schindelin > wrote: > > > > On Tue, 4 Apr 2017, Brandon Williams wrote: > > > >> I'm all for seeing a patch like this applied. I agree that we can't > >> expect the world

Segfault on git for Windows

2017-04-05 Thread Rémi Galan Alfonso
Hello, I am unsure whether it's Windows only or not, so I'm sending here and CCing Dscho. At $DAYWORK, the code is versionned under SVN. Since I haven't used SVN before and try to have a clean and bisectable history, I installed git with the intent to manage my code locally before pushing to SVN