Re: Bug Report - Segmentation Fault on "git add --all"

On 20 July 2017 at 02:54, Tillson Galloway wrote: > Context: > We currently have a git project with a root directory ("~/project") > for pipelines and deployment of a Node app, and then a subdirectory > ("~/project/project-app"). > After realizing that we didn't need

Re: [RFC PATCH v2 1/4] object: remove "used" field from struct object

On Wed, 19 Jul 2017 17:36:39 -0700 Stefan Beller wrote: > On Wed, Jul 19, 2017 at 5:21 PM, Jonathan Tan > wrote: > > The "used" field in struct object is only used by builtin/fsck. Remove > > that field and modify builtin/fsck to use a flag

Bug Report - Segmentation Fault on "git add --all"

Context: We currently have a git project with a root directory ("~/project") for pipelines and deployment of a Node app, and then a subdirectory ("~/project/project-app"). After realizing that we didn't need the node app in a subdirectory, we moved the full app into the root directory (using the

Re: [L10N] Kickoff of translation for Git 2.14.0 round 1

2017-07-19 13:44 GMT+08:00 Jordi Mas : > El 15/07/2017 a les 07:06, Jiang Xin ha escrit: >> > > Hello Jiang, > > Sometimes I do several commits to complete the translation. However, github > from the UI does not offer me the option to Merge and Squash. > > Can you check that

Re: [RFC PATCH v2 1/4] object: remove "used" field from struct object

On Wed, Jul 19, 2017 at 5:21 PM, Jonathan Tan wrote: > The "used" field in struct object is only used by builtin/fsck. Remove > that field and modify builtin/fsck to use a flag instead. The patch looks good to me (I would even claim this could go in as an independent

[RFC PATCH v2 3/4] sha1-array: support appending unsigned char hash

In a subsequent patch, sha1_file will need to append object names in the form of "unsigned char *" to oid arrays. Teach sha1-array support for that. Signed-off-by: Jonathan Tan --- sha1-array.c | 7 +++ sha1-array.h | 1 + 2 files changed, 8 insertions(+) diff

[RFC PATCH v2 4/4] sha1_file: support promised object hook

Teach sha1_file to invoke a hook whenever an object is requested and unavailable but is promised. The hook is a shell command that can be configured through "git config"; this hook takes in a list of hashes and writes (if successful) the corresponding objects to the repo's local storage. The

[RFC PATCH v2 2/4] promised-object, fsck: introduce promised objects

Currently, Git does not support repos with very large numbers of objects or repos that wish to minimize manipulation of certain blobs (for example, because they are very large) very well, even if the user operates mostly on part of the repo, because Git is designed on the assumption that every

[RFC PATCH v2 1/4] object: remove "used" field from struct object

The "used" field in struct object is only used by builtin/fsck. Remove that field and modify builtin/fsck to use a flag instead. Signed-off-by: Jonathan Tan --- builtin/fsck.c | 24 ++-- object.c | 1 - object.h | 2 +- 3 files

[RFC PATCH v2 0/4] Partial clone: promised objects (not only blobs)

Thanks for all your comments on the earlier version. This is a substantially different version. In particular: - Now supports all types (tag, commit, tree) of objects, not only blobs - fsck works - Incorporates Ben Peart's code that uses a long-living process (lifetime of the Git invocation)

Re: [RFC PATCH 2/3] sha1-array: support appending unsigned char hash

On Wed, Jul 19, 2017 at 4:56 PM, Jonathan Tan wrote: > On Tue, 11 Jul 2017 15:06:11 -0700 > Stefan Beller wrote: > >> On Tue, Jul 11, 2017 at 12:48 PM, Jonathan Tan >> wrote: >> > In a subsequent patch, sha1_file will need

Re: [RFC PATCH 2/3] sha1-array: support appending unsigned char hash

On Tue, 11 Jul 2017 15:06:11 -0700 Stefan Beller wrote: > On Tue, Jul 11, 2017 at 12:48 PM, Jonathan Tan > wrote: > > In a subsequent patch, sha1_file will need to append object names in the > > form of "unsigned char *" to oid arrays. Teach

Re: [RFC PATCH 1/3] promised-blob, fsck: introduce promised blobs

On Tue, 11 Jul 2017 15:02:09 -0700 Stefan Beller wrote: > Here I wondered what this file looks like, in a later patch you > add documentation: > > +objects/promisedblob:: > + This file records the sha1 object names and sizes of promised > + blobs. > + >

Re: [PATCH] fsck: remove redundant parse_tree() invocation

Hi, Jonathan Tan wrote: > If obj->type == OBJ_TREE, an invocation of fsck_walk() will invoke > parse_tree() and return quickly if that returns nonzero, so it is of no > use for traverse_one_object() to invoke parse_tree() in this situation > before invoking fsck_walk(). Remove that code. I like

Re: [PATCH] PRItime: wrap PRItime for better l10n compatibility

Johannes Schindelin writes: > But there may be hope. Since the character sequence "PRItime" is highly > unlikely to occur in Git's source code in any context other than the > format to print/parse timestamp_t, it should be possible to automate a the > string

Re: [PATCH] PRItime: wrap PRItime for better l10n compatibility

Johannes Schindelin writes: >> Gettext handles macros such as PRIuMAX in commit 8b45c5df1 ("Add >> support for ISO C 99 format string directive macros.", >> 2002-07-23 12:33:13 +). > > Wow. This is ugly. > > If I understand correctly, then this will not even work

Re: [PATCH] objects: scope count variable to loop

On 07/19, Stefan Beller wrote: > This is another test balloon to see if we get complaints from people > whose compilers do not support variables scoped to for loops. > > This part of the code base was chosen as it is very old code that does > not change often, such that a potential revert is

[PATCH] objects: scope count variable to loop

This is another test balloon to see if we get complaints from people whose compilers do not support variables scoped to for loops. This part of the code base was chosen as it is very old code that does not change often, such that a potential revert is easy. Signed-off-by: Stefan Beller

Re: subrepo vs submodule

On Wed, Jul 19, 2017 at 7:27 AM, Robert Dailey wrote: > So I found out about "subrepo" today: > https://github.com/ingydotnet/git-subrepo > > I'm still reading about how it works internally, but what do you guys > think about it? Nice find! >From reading the toplevel

Re: [PATCH] run_processes_parallel: change confusing task_cb convention

On Wed, Jul 19, 2017 at 7:56 AM, Johannes Schindelin wrote: > By declaring the task_cb parameter of type `void **`, the signature of > the get_next_task method suggests that the "task-specific cookie" can be > defined in that method, and the signatures of the

[PATCH] sha1_file: use access(), not lstat(), if possible

In sha1_loose_object_info(), use access() (indirectly invoked through has_loose_object()) instead of lstat() if we do not need the on-disk size, as it should be faster on Windows [1]. [1] https://public-inbox.org/git/alpine.DEB.2.21.1.1707191450570.4193@virtualbox/ Signed-off-by: Jonathan Tan

Handling of paths

Hello, I have a .gitconfig in which I try to separate work and private stuff by using includes which works great. When using [include] the path is treated either - relative to the including file (if the path itself relative) - relative to the home directory if it starts with ~ - absolute if the

Re: `make profile-fast` fails with "error: No $GIT_PERF_REPO defined, and your build directory is not a repo"

Hello again, In git/Makefile, we can see that `$(MAKE) PROFILE=GEN -j1 perf` is being skipped for the `profile` target when there is no `$GIT_PERF_REPO`: https://github.com/git/git/blob/cac25fc330fc26050dcbc92c4bfff169a4848e93/Makefile#L1769-L1782 However, the same is not true for the

[PATCH] run_processes_parallel: change confusing task_cb convention

By declaring the task_cb parameter of type `void **`, the signature of the get_next_task method suggests that the "task-specific cookie" can be defined in that method, and the signatures of the start_failure and of the task_finished methods declare that parameter of type `void *`, suggesting that

Re: [GSoC][PATCH 8/8] submodule: port submodule subcommand 'summary' from shell to C

On Tue, Jul 18, 2017 at 10:49 PM, Prathamesh Chavan wrote: > +static void print_submodule_summary(struct summary_cb *info, > + struct module_cb *p) > +{ > + int missing_src = 0; > + int missing_dst = 0; > + char

subrepo vs submodule

So I found out about "subrepo" today: https://github.com/ingydotnet/git-subrepo I'm still reading about how it works internally, but what do you guys think about it? Is it a more or less perfect alternative to submodules? What would be a reason not to use it?

Re: reftable [v2]: new ref storage format

On Tue, Jul 18 2017, Shawn Pearce jotted: > On Mon, Jul 17, 2017 at 12:51 PM, Junio C Hamano wrote: >> Shawn Pearce writes: >>> where `time_sec` is the update time in seconds since the epoch. The >>> `reverse_int32` function inverses the value so

Re: [GSoC][PATCH 6/8] submodule: port submodule subcommand 'deinit' from shell to C

On Tue, Jul 18, 2017 at 10:49 PM, Prathamesh Chavan wrote: > +static void deinit_submodule(const struct cache_entry *list_item, > +void *cb_data) > +{ > + struct deinit_cb *info = cb_data; > + const struct submodule *sub; > + char

Re: [PATCH] PRItime: wrap PRItime for better l10n compatibility

Hi Jian (or is it Xin?), On Wed, 19 Jul 2017, Jiang Xin wrote: > 2017-07-19 1:35 GMT+08:00 Junio C Hamano : > > Jiang Xin writes: > > > >>> Two potential issues are: > >>> > >>> - After this patch, there still are quite a many > >>> > >>>

Re: [PATCH v5 8/8] sha1_file: refactor has_sha1_file_with_flags

Hi Jonathan, On Tue, 18 Jul 2017, Jonathan Tan wrote: > On Tue, 18 Jul 2017 12:30:46 +0200 > Christian Couder wrote: > > > On Thu, Jun 22, 2017 at 2:40 AM, Jonathan Tan > > wrote: > > > > > diff --git a/sha1_file.c b/sha1_file.c > > >

[ANNOUNCE] Git Rev News edition 29

Hi everyone, The 29th edition of Git Rev News is now published: https://git.github.io/rev_news/2017/07/19/edition-29/ Thanks a lot to all the contributors and helpers! Enjoy, Christian, Thomas, Jakub and Markus.

`make profile-fast` fails with "error: No $GIT_PERF_REPO defined, and your build directory is not a repo"

Hello, I'm trying to build a profile-optimized Git. I used to do this with the following commands: mkdir /tmp/git cd /tmp/git curl https://www.kernel.org/pub/software/scm/git/git-2.13.3.tar.xz | tar xJ cd git-2.13.3 make prefix=/usr profile man -j18 sudo make prefix=/usr