[PATCH v4 09/19] log: add -P as a synonym for --perl-regexp

ed in the aforementioned commit the --basic-regexp option can't have a corresponding -G argument, as the log command already uses that for -G. Signed-off-by: Ævar Arnfjörð Bjarmason <ava...@gmail.com> --- Documentation/rev-list-options.txt | 1 + revision.c

[PATCH v4 07/19] grep: add a test for backreferences in PCRE patterns

Add a test for backreferences such as (.)\1 in PCRE patterns. This test ensures that the PCRE_NO_AUTO_CAPTURE option isn't turned on. Before this change turning it on would break these sort of patterns, but wouldn't break any tests. Signed-off-by: Ævar Arnfjörð Bjarmason <ava...@gmail.com>

[PATCH v4 04/19] grep: remove redundant regflags assignment under PCRE

ot;wait this is used under PCRE how?" confusion when reading the code, than to to save ourselves trivial CPU cycles by removing one assignment. Signed-off-by: Ævar Arnfjörð Bjarmason <ava...@gmail.com> --- grep.c | 1 - 1 file changed, 1 deletion(-) diff --git a/grep.c b/grep.c index 47

[PATCH v4 00/19] PCRE v1 improvements & PCRE v2 support

Trivial changes since last time. Just sending this because I'd like the copy in pu updated. Changes noted below: Ævar Arnfjörð Bjarmason (19): grep: amend submodule recursion test in preparation for rx engine testing grep: add tests for grep pattern types being passed to submodules A s

[PATCH v4 02/19] grep: add tests for grep pattern types being passed to submodules

long correctly. Signed-off-by: Ævar Arnfjörð Bjarmason <ava...@gmail.com> --- t/t7814-grep-recurse-submodules.sh | 49 ++ 1 file changed, 49 insertions(+) diff --git a/t/t7814-grep-recurse-submodules.sh b/t/t7814-grep-recurse-submodules.sh index 3c580b38b

[PATCH v4 12/19] test-lib: rename the LIBPCRE prerequisite to PCRE

e general name to make it clear that they work on both library versions. Signed-off-by: Ævar Arnfjörð Bjarmason <ava...@gmail.com> --- t/README | 4 ++-- t/t4202-log.sh | 10 +- t/t7810-grep.sh| 32 -

[PATCH v4 10/19] grep & rev-list doc: stop promising libpcre for --perl-regexp

patible regular expression support. By wording the documentation differently and not promising any specific version of PCRE or ever PCRE at all we have more wiggle room to change the implementation. Signed-off-by: Ævar Arnfjörð Bjarmason <ava...@gmail.com> --- Documentation/git-grep.txt

[PATCH v4 17/19] grep: add support for PCRE v2

19.172322.833ee099.en.html Signed-off-by: Ævar Arnfjörð Bjarmason <ava...@gmail.com> --- Documentation/config.txt | 14 ++-- Makefile | 18 + builtin/grep.c | 7 +- configure.ac | 49 ++

[PATCH v4 18/19] grep: remove support for concurrent use of both PCRE v1 & v2

cre1 & --with-libpcre2 to the configure script will produce an error. Signed-off-by: Ævar Arnfjörð Bjarmason <ava...@gmail.com> --- Documentation/config.txt | 7 Makefile | 36 +-- builtin/grep.c | 3 --

[PATCH v4 19/19] Makefile & configure: make PCRE v2 the default PCRE implementation

X'd asking users to just upgrade to v2. So it makes sense to give our downstream distributors a nudge to switch over to it. Signed-off-by: Ævar Arnfjörð Bjarmason <ava...@gmail.com> --- Makefile | 21 ++--- configure.ac | 18 +- 2 files changed, 19 inser

[PATCH v4 16/19] grep: add support for the PCRE v1 JIT API

ing, it'll only fail in cases where malloc() doesn't work, in which case we're screwed anyway. Signed-off-by: Ævar Arnfjörð Bjarmason <ava...@gmail.com> --- grep.c | 27 ++- grep.h | 5 + 2 files changed, 31 insertions(+), 1 deletion(-) diff --git a/grep.

[PATCH v4 11/19] grep: make grep.patternType=[pcre|pcre1] a synonym for "perl"

uot;pcre2" instead of "pcre1", and depending on how Git is compiled the more specific "pcre1" or "pcre2" pattern types might produce an error. Signed-off-by: Ævar Arnfjörð Bjarmason <ava...@gmail.com> --- Documentation/config.txt | 9 + g

[PATCH v4 08/19] log: add exhaustive tests for pattern style options & config

matching method than the one it's told to use. Signed-off-by: Ævar Arnfjörð Bjarmason <ava...@gmail.com> --- t/t4202-log.sh | 77 +- 1 file changed, 76 insertions(+), 1 deletion(-) diff --git a/t/t4202-log.sh b/t/t4202-log.sh index f57

[PATCH v4 15/19] perf: add a performance comparison test of grep -E and -P

igned-off-by: Ævar Arnfjörð Bjarmason <ava...@gmail.com> --- t/perf/p7820-grep-engines.sh | 25 + 1 file changed, 25 insertions(+) create mode 100755 t/perf/p7820-grep-engines.sh diff --git a/t/perf/p7820-grep-engines.sh b/t/perf/p7820-grep-engines.sh new file mode

BUG: wildmatches like foo/**/**/bar don't match properly due to internal optimizations

Thought I'd just start another thread for this rather than tack it onto the pathalogical case thread. In commit 4c251e5cb5 ("wildmatch: make /**/ match zero or more directories", 2012-10-15) Duy added support for ** in globs. One test-case for this is: match 1 0 'foo/baz/bar'

Re: [PATCH v3 0/5] clone: --no-tags option

On Thu, Apr 27, 2017 at 1:12 AM, Ævar Arnfjörð Bjarmason <ava...@gmail.com> wrote: > This is an expansion of the previously solo 02/05 "clone: add a > --no-tags option to clone without tags" patch (see > <20170418191553.15464-1-ava...@gmail.com>). > >

Re: [PATCH] tests: fix tests broken under GETTEXT_POISON=YesPlease

On Tue, Apr 25, 2017 at 6:11 AM, Junio C Hamano <gits...@pobox.com> wrote: > Ævar Arnfjörð Bjarmason <ava...@gmail.com> writes: > >> My general approach when writing & maintaining this poison has been >> that it's fine if we skip some tests, even though we could b

[PATCH] test: remove unused parameter from the wildmatch test

that the test would be skipped for fnmatch(). Support for that was implicitly added in commit feabcc173b ("Integrate wildmatch to git", 2012-10-15) by leaving out an "else" condition, and made use of starting in commit b79c0c3755 ("wildmatch: properly fold case everywhere

Re: [PATCH] test: remove unused parameter from the wildmatch test

On Tue, Apr 25, 2017 at 11:44 AM, Ævar Arnfjörð Bjarmason <ava...@gmail.com> wrote: > Remove the unused second parameter to the match() function. Since > commit 70a8fc999d ("stop using fnmatch (either native or compat)", > 2014-02-15) this hasn't been used, but was previou

Re: What's cooking in git.git (Apr 2017, #04; Wed, 19)

On Mon, Apr 24, 2017 at 4:19 PM, Johannes Schindelin wrote: > Hi Junio, > > On Sun, 23 Apr 2017, Junio C Hamano wrote: > >> Johannes Schindelin writes: >> >> > Part of the reason is that you push out all of the branches in one go, >> >

Re: [PATCH v3 2/5] clone: add a --no-tags option to clone without tags

On Thu, Apr 27, 2017 at 7:54 PM, Stefan Beller <sbel...@google.com> wrote: > On Wed, Apr 26, 2017 at 4:12 PM, Ævar Arnfjörð Bjarmason > <ava...@gmail.com> wrote: >> Add a --no-tags option to clone without fetching any tags. >> >> Without this change there

Re: [PATCH v3 0/5] clone: --no-tags option

On Fri, Apr 28, 2017 at 12:27 AM, Brandon Williams <bmw...@google.com> wrote: > On 04/26, Ævar Arnfjörð Bjarmason wrote: >> This is an expansion of the previously solo 02/05 "clone: add a >> --no-tags option to clone without tags" patch (see >> <

Re: [PATCH v3 3/5] tests: rename a test having to do with shallow submodules

On Fri, Apr 28, 2017 at 12:13 AM, Brandon Williams <bmw...@google.com> wrote: > On 04/27, Stefan Beller wrote: >> On Wed, Apr 26, 2017 at 4:12 PM, Ævar Arnfjörð Bjarmason >> <ava...@gmail.com> wrote: >> > Rename the t5614-clone-submodules.sh test to >>

Re: [PATCH] githooks.txt: clarify push hooks are always executed in $GIT_DIR

On Sat, Apr 29, 2017 at 2:28 PM, Simon Ruderich wrote: > Listing the specific hooks might feel verbose but without it the > reader is left to wonder which hooks are triggered during the > push. Something which is not immediately obvious when only trying > to find out where the

Re: What's cooking in git.git (Jul 2017, #09; Mon, 31)

On Thu, Aug 03 2017, Junio C. Hamano jotted: > Sahil Dua writes: > >> Ah! I had skipped this reply from Ramsay earlier. >> >> On Tue, Aug 1, 2017 at 1:36 AM, Ramsay Jones >> ... I personally do not think "branch --copy master backup" while on "master" that

Re: What's cooking in git.git (Jul 2017, #09; Mon, 31)

On Mon, Aug 07 2017, Igor Djordjevic jotted: > On 07/08/2017 23:25, Igor Djordjevic wrote: >> On 06/08/2017 22:26, Ævar Arnfjörð Bjarmason wrote: >>> On Sat, Aug 05 2017, Junio C. Hamano jotted: >>>> I actually consider "branch" to *never* invoking a chec

Re: [PATCH 0/4] dropping support for older curl

On Wed, Aug 09 2017, Johannes Schindelin jotted: > Hi Peff, > > On Wed, 9 Aug 2017, Jeff King wrote: > >> This is a resurrection of the thread from April: >> >> >> https://public-inbox.org/git/20170404025438.bgxz5sfmrawqs...@sigill.intra.peff.net/ > > As before, I would like to point out that

Re: [PATCH 3/4] http: drop support for curl < 7.19.4

On Wed, Aug 09 2017, Jeff King jotted: > Since v2.12.0, Git does not compile with versions of curl > older than 7.19.4. That version of curl is about 8 years > old. This means it may still be used in some distributions > with long-running support periods. But the fact that we > haven't received

[PATCH 5/4] curl: remove ifdef'd code never used with curl >=7.19.4

H(3)). The CURLOPT_USE_SSL macro used since [2] was added in 7.16.4 (see CURLOPT_USE_SSL(3)). 1. 40a18fc77c ("http: add an "auto" mode for http.emptyauth", 2017-02-25) 2. 4bc444eb64 ("Support FTP-over-SSL/TLS for regular FTP", 2013-04-07) Signed-off-by: Ævar Arnfjörð Bjarmason <

Re: [RFC] clang-format: outline the git project's coding style

On Wed, Aug 09 2017, Jeff King jotted: > On Mon, Aug 07, 2017 at 06:25:54PM -0700, Brandon Williams wrote: > >> I'm sure this sort of thing comes up every so often on the list but back at >> git-merge I mentioned how it would be nice to not have to worry about style >> when reviewing patches as

Re: upgarding GIT

On Mon, Aug 07 2017, James Wells jotted: > Hi All > > I am fairly new to git, however I have a challenge of upgrading git from > 2.0.4 to 2.4.12 and my initial 2.0.4 install was done via TAR BALL on my > server. > > I have a centos server running git and Atlassian STASH and my challenge is >

Re: [PATCH] tests: don't give unportable ">" to "test" built-in, use -gt

On Mon, Aug 07 2017, René Scharfe jotted: > Am 07.08.2017 um 03:18 schrieb brian m. carlson: >> On Sun, Aug 06, 2017 at 11:38:50PM +0000, Ævar Arnfjörð Bjarmason wrote: >>> Change an argument to test_line_count (which'll ultimately be turned >>> into a "test&q

Re: reftable [v5]: new ref storage format

On Sun, Aug 06 2017, Shawn Pearce jotted: > 5th iteration of the reftable storage format. I haven't kept up with all of the discussion, sorry if these comments repeat something that's already mentioned. > ### Version 1 > > A repository must set its `$GIT_DIR/config` to configure reftable: > >

[PATCH] tests: don't give unportable ">" to "test" built-in, use -gt

o tag/branch/for-each-ref", 2017-03-24). Upstream just worked around it by patching git and didn't tell us about it, I discovered this when reading various Git packaging implementations: https://github.com/openbsd/ports/commit/7e48bf88a20 Signed-off-by: Ævar Arnfjörð Bjarmason <ava...@g

Re: What's cooking in git.git (Jul 2017, #09; Mon, 31)

On Sat, Aug 05 2017, Junio C. Hamano jotted: > Ævar Arnfjörð Bjarmason <ava...@gmail.com> writes: > >> We've talked how this UX should look before on-list. Rather than >> re-hashing the arguments I had before I thought it was useful to present >> it as a table.

Re: PCRE v2 compile error, was Re: What's cooking in git.git (May 2017, #01; Mon, 1)

[Just replying to you & Duy in the same mail, easier] On Wed, May 3, 2017 at 11:45 AM, Johannes Schindelin <johannes.schinde...@gmx.de> wrote: > Hi Ævar, > > On Tue, 2 May 2017, Ævar Arnfjörð Bjarmason wrote: > >> On Tue, May 2, 2017 at 6:05 PM, Johannes Schindelin &g

[PATCH] config.mak.uname: set NO_REGEX=NeedsStartEnd on AIX

are/commit/e247e36761#diff-3df898345d670979b74acc0bf71d8c47 2. https://www.ibm.com/support/knowledgecenter/ssw_aix_72/com.ibm.aix.basetrf2/regexec.htm Signed-off-by: Ævar Arnfjörð Bjarmason <ava...@gmail.com> --- config.mak.uname | 1 + 1 file changed, 1 insertion(+) diff --git a/config.mak.uname b/

Re: Proposal for missing blob support in Git repos

On Tue, May 2, 2017 at 7:21 PM, Jonathan Tan wrote: > On Mon, May 1, 2017 at 6:41 PM, Junio C Hamano wrote: >> Jonathan Tan writes: >> >>> On 05/01/2017 04:29 PM, Junio C Hamano wrote: Jonathan Tan

Re: PCRE v2 compile error, was Re: What's cooking in git.git (May 2017, #01; Mon, 1)

On Tue, May 2, 2017 at 7:43 PM, Brandon Williams <bmw...@google.com> wrote: > On 05/02, Ævar Arnfjörð Bjarmason wrote: >> On Tue, May 2, 2017 at 2:09 PM, Johannes Schindelin >> <johannes.schinde...@gmx.de> wrote: >> > Hi Ævar, >> > >> > On S

Re: PCRE v2 compile error, was Re: What's cooking in git.git (May 2017, #01; Mon, 1)

On Tue, May 2, 2017 at 6:05 PM, Johannes Schindelin <johannes.schinde...@gmx.de> wrote: > Hi Ævar, > > On Tue, 2 May 2017, Ævar Arnfjörð Bjarmason wrote: > >> On Tue, May 2, 2017 at 2:09 PM, Johannes Schindelin >> <johannes.schinde...@gmx.de> wrote: >>

Re: [PATCH v2 4/7] grep: add support for the PCRE v1 JIT API

On Sun, May 14, 2017 at 5:10 PM, Ævar Arnfjörð Bjarmason <ava...@gmail.com> wrote: > On Sun, May 14, 2017 at 4:43 PM, Simon Ruderich <si...@ruderich.org> wrote: >> On Sat, May 13, 2017 at 11:45:32PM +, Ęvar Arnfjörš Bjarmason wrote: >>> [snip] >>> >

Re: [PATCH v2 4/7] grep: add support for the PCRE v1 JIT API

On Sun, May 14, 2017 at 4:43 PM, Simon Ruderich wrote: > On Sat, May 13, 2017 at 11:45:32PM +, Ęvar Arnfjörš Bjarmason wrote: >> [snip] >> >> +#ifdef PCRE_CONFIG_JIT >> + if (p->pcre1_jit_on) >> + ret = pcre_jit_exec(p->pcre1_regexp, p->pcre1_extra_info,

Re: [PATCH] compat/regex: fix compilation on Windows

On Thu, May 11, 2017 at 3:50 PM, Johannes Schindelin wrote: > The real issue here is that GNU awk's regex implementation assumes a bit > too much about the relative sizes of pointers and long integers. What they > really want is to use intptr_t. > > This patch

Re: [PATCH] config: complain about --local outside of a git repo

On Fri, May 12, 2017 at 10:34 PM, Jeff King wrote: > On Fri, May 12, 2017 at 10:19:59AM -0400, Josh Hagins wrote: > >> Since upgrading to Git 2.13.0 I'm seeing this error message whenever >> `git config --local ` is called outside a Git repository. >> For example, note the

Re: [RFC] send-email: support validate hook

On Sat, May 13, 2017 at 12:31 AM, Jonathan Tan <jonathanta...@google.com> wrote: > On 05/12/2017 12:23 AM, Ævar Arnfjörð Bjarmason wrote: >> >> I hacked this up last night, it also addresses Junio's comment about >> GIT_DIR: >> > [snip] >> >> >>

Re: What's cooking in git.git (May 2017, #04; Fri, 12)

On Fri, May 12, 2017 at 8:43 AM, Junio C Hamano wrote: > * ab/grep-preparatory-cleanup (2017-05-12) 15 commits > - grep: add tests to fix blind spots with \0 patterns > - grep: prepare for testing binary regexes containing rx metacharacters > - SQUASH??? > - grep: add a

Re: [RFC] send-email: support validate hook

On Thu, May 11, 2017 at 9:37 PM, Jonathan Tan wrote: > Currently, send-email has support for rudimentary e-mail validation. > Allow the user to add support for more validation by providing a > sendemail-validate hook. > > Signed-off-by: Jonathan Tan

Re: What's cooking in git.git (May 2017, #04; Fri, 12)

On Fri, May 12, 2017 at 10:44 AM, Junio C Hamano <gits...@pobox.com> wrote: > Ævar Arnfjörð Bjarmason <ava...@gmail.com> writes: > >> On Fri, May 12, 2017 at 8:43 AM, Junio C Hamano <gits...@pobox.com> wrote: >>> * ab/grep-preparatory-cleanup (2017-05-12) 1

Re: Possible bug in includeIf / conditional includes on non git initialised directories

On Thu, May 11, 2017 at 8:53 PM, Raphael Stolt wrote: > Hi there, > > I might have stumbled this time over a real bug in includeIf / conditional > includes or maybe it's just as intended. > 1) Given I have a correct configured includeIf and I’m issuing `git config >

[PATCH] tag: duplicate mention of --contains should mention --no-contains

Fix a duplicate mention of --contains in the SYNOPSIS to mention --no-contains. This fixes an error introduced in my commit ac3f5a3468 ("ref-filter: add --no-contains option to tag/branch/for-each-ref", 2017-03-24). Signed-off-by: Ævar Arnfjörð Bjarmason <ava...@gmail.com> --- D

Git 2.13.0 segfaults on Solaris SPARC due to DC_SHA1=YesPlease being on by default

Since 2.13.0 just running "git status" on a newly init'd repo on Solaris SPARC[1] segfaults. Michael (CC'd) reported this issue on #git and I helped him debug it. Just compiling with BLK_SHA1=YesPlease solves the issue. There are at least two different issues with DC_SHA1 here: * We don't

Re: Git 2.13.0 segfaults on Solaris SPARC due to DC_SHA1=YesPlease being on by default

g to some info I found online that should give a SIGBUS not a SIGSEGV, but that may have changed: https://bugs.python.org/issue12181 https://github.com/magnumripper/JohnTheRipper/issues/2187 > Best regards, > Marc Stevens > > -Oorspronkelijk bericht- > Van: Ævar Arnfjörð B

Re: [PATCH] tag: duplicate mention of --contains should mention --no-contains

On Mon, May 15, 2017 at 4:20 PM, Marc Branchaud <marcn...@xiplink.com> wrote: > On 2017-05-15 08:23 AM, Ævar Arnfjörð Bjarmason wrote: >> >> Fix a duplicate mention of --contains in the SYNOPSIS to mention >> --no-contains. >> >> This fixes an error introduc

Re: [Query] Override sendemail.tocmd

On Wed, May 10, 2017 at 9:23 AM, Viresh Kumar wrote: > Hi, > > I have a use case and wanted help from you guys.. > > I have set the sendemail.tocmd option in my kernel's .git/config > file and that works very well. But sometimes I want to avoid that > (for example sending

[PATCH v3 1/2] perf: add function to setup a fresh test repo

ions or files, which I'm about to add in a subsequent commit. Signed-off-by: Ævar Arnfjörð Bjarmason <ava...@gmail.com> --- t/perf/README | 1 + t/perf/perf-lib.sh | 17 + 2 files changed, 14 insertions(+), 4 deletions(-) diff --git a/t/perf/README b/t/perf/README index

[PATCH v3 0/2] perf: show that wildmatch() regressed for pathological cases in v2.0

= 6 0.00(0.00+0.00) 2.75(2.73+0.00) +inf Ævar Arnfjörð Bjarmason (2): perf: add function to setup a fresh test repo perf: add test showing exponential growth in path globbing t/perf/README| 1 + t/perf/p0100-globbing.sh | 43 +++ t/

[PATCH v3 2/2] perf: add test showing exponential growth in path globbing

this is a test to see whether Git suffers from the issue noted in an article Russ Cox posted today about common bugs in various glob implementations: https://research.swtch.com/glob Signed-off-by: Ævar Arnfjörð Bjarmason <ava...@gmail.com> --- t/perf/p0100-globbing.s

Re: https://travis-ci.org/git/git/builds/

On Thu, May 11, 2017 at 9:46 AM, Junio C Hamano wrote: > I was hoping that by ejecting a few topics out of 'pu', we could > finally see all the build jobs pass their tests under Travis CI. > Unfortunately, no such luck. It seems that we have some new issues > with

Re: Possible bug in includeIf / conditional includes

On Thu, May 11, 2017 at 9:42 AM, Jeff King <p...@peff.net> wrote: > On Thu, May 11, 2017 at 09:19:50AM +0200, Ævar Arnfjörð Bjarmason wrote: > >> 1. It says "The included file is expanded immediately, as if its >> contents had been found at the location of the inclu

Re: Possible bug in includeIf / conditional includes

On Thu, May 11, 2017 at 8:29 AM, Jeff King wrote: > On Thu, May 11, 2017 at 02:26:16AM -0400, Jeff King wrote: > >> > So whether this is a bug in the code or not it seems to definitely be >> > a doc bug, whatever it does with relative files should be in the docs. >> >> The

Re: [PATCH] compat/regex: fix compilation on Windows

On Thu, May 11, 2017 at 3:50 PM, Johannes Schindelin wrote: > The real issue here is that GNU awk's regex implementation assumes a bit > too much about the relative sizes of pointers and long integers. What they > really want is to use intptr_t. Thanks, looks good! >

[PATCH v2 2/2] perf: add test showing exponential growth in path globbing

aa.." as git-ls-files will. I'm unsure why the pathological case isn't triggered by for-each-ref, but in any case, now we have a performance test for it. Signed-off-by: Ævar Arnfjörð Bjarmason <ava...@gmail.com> --- t/perf/p0100-globbing.sh | 48 ++

[PATCH v2 1/2] perf: add function to setup a fresh test repo

I'm about to add in a subsequent commit. Signed-off-by: Ævar Arnfjörð Bjarmason <ava...@gmail.com> --- t/perf/README | 1 + t/perf/perf-lib.sh | 17 + 2 files changed, 14 insertions(+), 4 deletions(-) diff --git a/t/perf/README b/t/perf/README index 49ea4349be..de2fe15

[PATCH v2 0/2] perf: show that wildmatch() regressed for pathological cases in v2.0

This is a re-send of <20170424211249.28553-1-ava...@gmail.com> (https://public-inbox.org/git/20170424211249.28553-1-ava...@gmail.com/) which fell through the cracks at the time. The only change is a typo fix in the description of the test in 2/2. Ævar Arnfjörð Bjarmason (2): perf: add fu

Re: [PATCH v2 1/2] perf: add function to setup a fresh test repo

On Thu, May 11, 2017 at 1:30 AM, Jonathan Nieder wrote: > Hi, > > Ęvar Arnfjörš Bjarmason wrote: > > [...] >> # call at least one of these to establish an appropriately-sized repository >> +test_perf_fresh_repo () { >> + repo="${1:-$TRASH_DIRECTORY}" >> +

[PATCH 00/29] Easy to review grep & pre-PCRE changes

read configuration under NO_PTHREADS=Y. Ævar Arnfjörð Bjarmason (29): Makefile & configure: reword inaccurate comment about PCRE grep & rev-list doc: stop promising libpcre for --perl-regexp test-lib: rename the LIBPCRE prerequisite to PCRE log: add exhaustive tests for pattern style opti

[PATCH 06/29] grep: add a test for backreferences in PCRE patterns

Add a test for backreferences such as (.)\1 in PCRE patterns. This test ensures that the PCRE_NO_AUTO_CAPTURE option isn't turned on. Before this change turning it on would break these sort of patterns, but wouldn't break any tests. Signed-off-by: Ævar Arnfjörð Bjarmason <ava...@gmail.com>

[PATCH 4/7] grep: add support for the PCRE v1 JIT API

info. There's no graceful fallback if pcre_jit_stack_alloc() fails under PCRE_CONFIG_JIT, instead the program will simply abort. I don't think this is worth handling gracefully, it'll only fail in cases where malloc() doesn't work, in which case we're screwed anyway. Signed-off-by: Ævar Arnfjörð

[PATCH 5/7] grep: un-break building with PCRE < 8.32

rsions. 1. http://www.pcre.org/original/changelog.txt ("28. Introducing a native interface for JIT. Through this interface, the compiled[...]") 2. https://bugs.exim.org/show_bug.cgi?id=2121 Signed-off-by: Ævar Arnfjörð Bjarmason <ava...@gmail.com> --- grep.c | 8

[PATCH 7/7] grep: add support for PCRE v2

m, but makes the code look nicer. 1. https://lists.exim.org/lurker/message/20150105.162835.0666407a.en.html 2. https://lists.exim.org/lurker/thread/20170419.172322.833ee099.en.html Signed-off-by: Ævar Arnfjörð Bjarmason <ava...@gmail.com> --- Makefile | 30 +--- configure.ac |

[PATCH 3/7] log: add -P as a synonym for --perl-regexp

ment, as the log command already uses that for -G. Signed-off-by: Ævar Arnfjörð Bjarmason <ava...@gmail.com> --- Documentation/rev-list-options.txt | 1 + revision.c | 2 +- t/t4202-log.sh | 12 3 files changed, 14 insertions

[PATCH 6/7] grep: un-break building with PCRE < 8.20

han 7.5 as I'm confident that if the build breaks on those older versions it's not because of my JIT change. See the "un-break" change in this series ("grep: un-break building with PCRE < 8.32", 2017-05-10) for why this isn't squashed into the main PCRE JIT commit. Signed

[PATCH 2/7] grep: skip pthreads overhead when using one thread

tirely when 1 thread is requested. Signed-off-by: Ævar Arnfjörð Bjarmason <ava...@gmail.com> --- builtin/grep.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/builtin/grep.c b/builtin/grep.c index 7baa4778b7..9c0d1ecc12 100644 --- a/builtin/grep.c +++ b/builtin/grep.c @@ -1240,6 +1240,

[PATCH 0/7] PCRE v2, PCRE v1 JIT, log -P & fixes

easier for everyone to bundle these up, since they all go on top of the other series. Comments below: Ævar Arnfjörð Bjarmason (7): grep: don't redundantly compile throwaway patterns under threading grep: skip pthreads overhead when using one thread Internal changes to grep to not redun

[PATCH 1/7] grep: don't redundantly compile throwaway patterns under threading

c7 ("grep: teach --debug option to dump the parse tree", 2012-09-13) still works properly with this change. It only emits debugging info during pattern compilation, which is now dumped by the pattern compiled just before the first thread is started. Signed-off-by: Ævar Arnfjörð Bjarmason <a

[PATCH 01/29] Makefile & configure: reword inaccurate comment about PCRE

ere they make less sense is the pattern everything else follows in that file. I'm not going to war against that as part of this change, just following the existing pattern. Signed-off-by: Ævar Arnfjörð Bjarmason <ava...@gmail.com> --- Makefile | 6 -- configure.ac | 12

[PATCH 03/29] test-lib: rename the LIBPCRE prerequisite to PCRE

e general name to make it clear that they work on both library versions. Signed-off-by: Ævar Arnfjörð Bjarmason <ava...@gmail.com> --- t/README| 4 ++-- t/t7810-grep.sh | 28 ++-- t/t7812-grep-icase-non-ascii.sh | 4 ++-- t/t78

[PATCH 02/29] grep & rev-list doc: stop promising libpcre for --perl-regexp

lar expression support. By wording the documentation differently and not promising any specific version of PCRE or even PCRE at all we have more wiggle room to change the implementation. Signed-off-by: Ævar Arnfjörð Bjarmason <ava...@gmail.com> --- Documentation/git-grep.txt | 7 +--

[PATCH 04/29] log: add exhaustive tests for pattern style options & config

matching method than the one it's told to use. Signed-off-by: Ævar Arnfjörð Bjarmason <ava...@gmail.com> --- t/t4202-log.sh | 77 +- 1 file changed, 76 insertions(+), 1 deletion(-) diff --git a/t/t4202-log.sh b/t/t4202-log.sh index f57

[PATCH 10/29] grep: add tests for grep pattern types being passed to submodules

long correctly. Signed-off-by: Ævar Arnfjörð Bjarmason <ava...@gmail.com> --- t/t7814-grep-recurse-submodules.sh | 49 ++ 1 file changed, 49 insertions(+) diff --git a/t/t7814-grep-recurse-submodules.sh b/t/t7814-grep-recurse-submodules.sh index 3c580b38b

[PATCH 12/29] grep: prepare for testing binary regexes containing rx metacharacters

mp; non-ASCII data. Signed-off-by: Ævar Arnfjörð Bjarmason <ava...@gmail.com> --- t/t7008-grep-binary.sh | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/t/t7008-grep-binary.sh b/t/t7008-grep-binary.sh index 6c1952eafa..1afba6cee9 100755 --- a/t/t7008-grep-binary.sh +++

[PATCH 13/29] grep: add tests to fix blind spots with \0 patterns

the a previous commit in this series ("grep: add tests to fix blind spots with \0 patterns", 2017-04-21) for further details & rationale. Signed-off-by: Ævar Arnfjörð Bjarmason <ava...@gmail.com> --- t/t7008-grep-binary.sh | 71 ++

[PATCH 18/29] grep: catch a missing enum in switch statement

nally recurse into submodules", 2016-12-16) for the initial addition of this code. Signed-off-by: Ævar Arnfjörð Bjarmason <ava...@gmail.com> --- builtin/grep.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/builtin/grep.c b/builtin/grep.c index 3ffb5b4e81..1c0adb30f3 1006

[PATCH 09/29] grep: amend submodule recursion test for regex engine testing

tests for pattern style options & config", 2017-04-07). The pattern "(.|.)[\d]" will match this content differently under fixed/basic/extended & perl. This test code was originally added in commit 0281e487fd ("grep: optionally recurse into submodules", 2016-1

[PATCH 21/29] grep: factor test for \0 in grep patterns into a function

compiling a pattern containing a \0. Factoring this out makes a subsequent change which does that smaller. See a previous commit in this series ("grep: add tests to fix blind spots with \0 patterns", 2017-04-21) for further details & rationale. Signed-off-by: Ævar Arnfjörð Bja

[PATCH 25/29] test-lib: add a PTHREADS prerequisite

Add a PTHREADS prerequisite which is false when git is compiled with NO_PTHREADS=YesPlease. There's lots of custom code that runs when threading isn't available, but before this prerequisite there was no way to test it. Signed-off-by: Ævar Arnfjörð Bjarmason <ava...@gmail.com> --- Ma

[PATCH 16/29] perf: add a performance comparison test of grep -G, -E and -P

15: perl grep (e.t[^ ]*|v.ry) rare3.58(3.40+0.17) 7820.17: basic grep m\(ú\|u\)ult.b\(æ\|y\)te 1.04(0.77+0.24) 7820.18: extended grep m(ú|u)ult.b(æ|y)te 1.03(0.81+0.20) 7820.19: perl grep m(ú|u)ult.b(æ|y)te 1.23(0.98+0.24) Signed-off-by: Ævar Arnfjörð Bjarmason <ava

Re: [PATCH v2 1/2] perf: add function to setup a fresh test repo

On Thu, May 11, 2017 at 11:55 AM, Junio C Hamano <gits...@pobox.com> wrote: > Ævar Arnfjörð Bjarmason <ava...@gmail.com> writes: > >> On Thu, May 11, 2017 at 1:30 AM, Jonathan Nieder <jrnie...@gmail.com> wrote: >>> Hi, >>> >>> Ęvar Arnfjörš

Re: [PATCH v2 1/3] usability: don't ask questions if no reply is required

On Thu, May 11, 2017 at 12:28 PM, Konstantin Khomoutov wrote: > On Thu, May 11, 2017 at 10:10:05AM +, Kerry, Richard wrote: > > [...] >> > > @@ -1940,7 +1940,7 @@ static void am_resolve(struct am_state *state) >> > > >> > > if (unmerged_cache()) { >> > >

[PATCH 05/29] grep: add a test asserting that --perl-regexp dies when !PCRE

--perl-regexp or -P. Signed-off-by: Ævar Arnfjörð Bjarmason <ava...@gmail.com> --- t/t4202-log.sh | 3 +++ t/t7810-grep.sh | 12 2 files changed, 15 insertions(+) diff --git a/t/t4202-log.sh b/t/t4202-log.sh index 6d1411abea..b0122a1991 100755 --- a/t/t4202-log.sh +++ b/t/t4

[PATCH 15/29] perf: emit progress output when unpacking & building

what's going on and what revision is being tested as the output scrolls by. Signed-off-by: Ævar Arnfjörð Bjarmason <ava...@gmail.com> --- t/perf/run | 2 ++ 1 file changed, 2 insertions(+) diff --git a/t/perf/run b/t/perf/run index b61024a830..beb4acc0e4 100755 --- a/t/perf/run +++ b/

[PATCH 07/29] grep: change non-ASCII -i test to stop using --debug

wsset when -F is specified", 2016-06-25). It was asserting that the regex must be compiled with compile_fixed_regexp(), instead test for the expected results, allowing the underlying implementation to change. Signed-off-by: Ævar Arnfjörð Bjarmason <ava...@gmail.com> --- t/t7812-grep-ic

[PATCH 11/29] grep: add a test helper function for less verbose -f \0 tests

Add a helper function to make the tests which check for patterns with \0 in them more succinct. Right now this isn't a big win, but subsequent commits will add a lot more of these tests. The helper is based on the match() function in t3070-wildmatch.sh. Signed-off-by: Ævar Arnfjörð Bjarmason

[PATCH 14/29] perf: add a GIT_PERF_MAKE_COMMAND for when *_MAKE_OPTS won't do

Signed-off-by: Ævar Arnfjörð Bjarmason <ava...@gmail.com> --- Makefile | 3 +++ t/perf/README | 19 +-- t/perf/run| 11 +-- 3 files changed, 29 insertions(+), 4 deletions(-) diff --git a/Makefile b/Makefile index eedadb8056..d1587452f1 100644 --- a/Makefile

[PATCH 08/29] grep: add tests for --threads=N and grep.threads

2 are special modes of operation. Signed-off-by: Ævar Arnfjörð Bjarmason <ava...@gmail.com> --- t/t7810-grep.sh | 16 1 file changed, 16 insertions(+) diff --git a/t/t7810-grep.sh b/t/t7810-grep.sh index daa906b9b0..561709ef6a 100755 --- a/t/t7810-grep.sh +++ b/t/t7810-grep.s

[PATCH 19/29] grep: remove redundant regflags assignment under PCRE

ot;wait this is used under PCRE how?" confusion when reading the code, than to to save ourselves trivial CPU cycles by removing one assignment. Signed-off-by: Ævar Arnfjörð Bjarmason <ava...@gmail.com> --- grep.c | 1 - 1 file changed, 1 deletion(-) diff --git a/grep.c b/grep.c index 47

[PATCH 24/29] grep: move two functions to avoid forward declaration

Move the is_fixed() and has_null() functions which are currently only used in compile_regexp() earlier so they can be used in the PCRE family of functions in a later change. Signed-off-by: Ævar Arnfjörð Bjarmason <ava...@gmail.com> --- grep.

[PATCH 28/29] grep: given --threads with NO_PTHREADS=YesPlease, warn

able via pack.threads, and have long warned about the same under NO_PTHREADS=YesPlease. Signed-off-by: Ævar Arnfjörð Bjarmason <ava...@gmail.com> --- builtin/grep.c | 11 +++ t/t7810-grep.sh | 18 ++ 2 files changed, 29 insertions(+) diff --git a/builtin/grep.c b/builti

[PATCH 27/29] pack-objects: fix buggy warning about threads

uot;pack.threads" & --threads. Solve this bug by resetting the delta_search_threads variable in git_pack_config(), it might then be set by --threads again and be subsequently warned about, as the test I'm changing here asserts. Signed-off-by: Ævar Arnfjörð Bjarmason <ava...@gmail.com

[PATCH 29/29] grep: assert that threading is enabled when calling grep_{lock,unlock}

n unless we're spawning threads. Signed-off-by: Ævar Arnfjörð Bjarmason <ava...@gmail.com> --- builtin/grep.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/builtin/grep.c b/builtin/grep.c index f4e08dd2b6..50e4bd2cd2 100644 --- a/builtin/grep.c +++ b/builtin/gre

<    2   3   4   5   6   7   8   9   10   11   >